planner: update the plan cache strategy when expressions with parameters affect null-check (#40218)#40476
Merged
ti-chi-bot merged 10 commits intopingcap:release-6.1from Jan 17, 2023
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Merged
12 tasks
Member
Author
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
chrysan
approved these changes
Jan 10, 2023
Contributor
|
/test unit-test |
…/ti-chi-bot/tidb into cherry-pick-40218-to-release-6.1
qw4990
reviewed
Jan 16, 2023
| tk.MustExec("alter table t add c int") | ||
|
|
||
| // confirm schema changed | ||
| time.Sleep(time.Millisecond * 20) |
fzzf678
approved these changes
Jan 16, 2023
Contributor
|
/test unit-test |
Contributor
|
/merge |
Member
Author
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: e673803 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #40218
What problem does this PR solve?
Issue Number: close #40093, close #38205
Problem Summary: planner: update the plan cache strategy when expressions with parameters affect null-check
What is changed and how it works?
When expressions with parameters affect null-check, process null-check and skip plan-cache instead of skipping the null-check and caching a sub-optimal plan.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.