Skip to content

ttl: add ttl_job_interval attribute and remove tidb_ttl_job_interval variable (#40033)#40372

Closed
ti-chi-bot wants to merge 1 commit intopingcap:release-6.5from
ti-chi-bot:cherry-pick-40033-to-release-6.5
Closed

ttl: add ttl_job_interval attribute and remove tidb_ttl_job_interval variable (#40033)#40372
ti-chi-bot wants to merge 1 commit intopingcap:release-6.5from
ti-chi-bot:cherry-pick-40033-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jan 6, 2023

This is an automated cherry-pick of #40033

Signed-off-by: YangKeao yangkeao@chunibyo.icu

What problem does this PR solve?

Issue Number: close #40028

Problem Summary:

The global config tidb_ttl_job_interval is not flexible enough. We could add an attribute for every table to configure different scan / delete frequency.

What is changed and how it works?

Add a new attribute ttl_job_interval to the table, and use this attribute to decide whether this job could be scheduled.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Allow configuring different ttl job frequency for tables.

@YangKeao @ti-chi-bot
This is an automated cherry-pick of pingcap#40033
3c5ea36 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot requested a review from a team as a code owner January 6, 2023 09:58
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 6, 2023
Merged
4 tasks
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jan 6, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jan 6, 2023
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jan 6, 2023

@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Feb 10, 2023

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 3c5ea36 link true /test check-dev2
idc-jenkins-ci-tidb/build 3c5ea36 link true /test build
idc-jenkins-ci-tidb/check_dev 3c5ea36 link true /test check-dev
idc-jenkins-ci-tidb/unit-test 3c5ea36 link true /test unit-test
idc-jenkins-ci-tidb/mysql-test 3c5ea36 link true /test mysql-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Feb 10, 2023

/hold high priority for trunk branch

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2023
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Feb 10, 2023

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2023
@YangKeao YangKeao closed this Mar 21, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-40033-to-release-6.5 branch April 15, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @wuhuizuo @YangKeao