Skip to content

ttl, domain: setup a customized session pool with stats collector (#40171)#40233

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-40171-to-release-6.5
Aug 17, 2023
Merged

ttl, domain: setup a customized session pool with stats collector (#40171)#40233
ti-chi-bot[bot] merged 2 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-40171-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 29, 2022

This is an automated cherry-pick of #40171

Signed-off-by: YangKeao yangkeao@chunibyo.icu

What problem does this PR solve?

Issue Number: close #40109

Problem Summary:

The table stats are not updated after ttl job.

What is changed and how it works?

Construct a new session pool with stats collector attached.

The do.sysSessionPool cannot have stats collector attached, because the stats handler are also using the session in this session pool, which obviously should not be collected (or it will result in endless recursive).

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Fix the issue that ttl deletion is not recorded in the statistics information.

@YangKeao @ti-chi-bot
use attachStatsCollector and detachStatsCollector to add or remove st…
4ca6a36 
…ats collector from ttlworker

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Dec 29, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lcwangchao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 29, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 29, 2022
Merged
4 tasks
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Dec 29, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 10, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 10, 2023
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels Mar 3, 2023
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels Apr 12, 2023
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Jun 5, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 14, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 6, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 15, 2023
YangKeao
YangKeao approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 17, 2023
@YangKeao
Copy link
Member

YangKeao commented Aug 17, 2023

/retest

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 17, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [YangKeao,lcwangchao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 17, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 17, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-17 03:16:11.554244447 +0000 UTC m=+773736.103260434: ☑️ agreed by YangKeao.
  • 2023-08-17 03:22:16.122295579 +0000 UTC m=+774100.671311566: ☑️ agreed by lcwangchao.

@YangKeao
Copy link
Member

YangKeao commented Aug 17, 2023

/retest

2 similar comments
@YangKeao
Copy link
Member

YangKeao commented Aug 17, 2023

/retest

@YangKeao
Copy link
Member

YangKeao commented Aug 17, 2023

/retest

@YangKeao
stop TTL in test to avoid data race
8239759 
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@YangKeao YangKeao force-pushed the cherry-pick-40171-to-release-6.5 branch from bcbbf26 to 8239759 Compare August 17, 2023 07:27
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@706c3fa). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #40233   +/-   ##
================================================
  Coverage               ?   73.6745%           
================================================
  Files                  ?       1084           
  Lines                  ?     347857           
  Branches               ?          0           
================================================
  Hits                   ?     256282           
  Misses                 ?      75118           
  Partials               ?      16457

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 17, 2023

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/mysql-test 8239759 link unknown /test mysql-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@YangKeao
Copy link
Member

YangKeao commented Aug 17, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit b606a97 into pingcap:release-6.5 Aug 17, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-40171-to-release-6.5 branch April 15, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcwangchao lcwangchao lcwangchao approved these changes

@YangKeao YangKeao YangKeao approved these changes

Assignees

No one assigned

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @YangKeao @lcwangchao @VelocityLight