Skip to content

ddl: fix waiting for wrong schema version if TiDB server restart (#39985)#40056

Merged
ti-chi-bot merged 6 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-39985-to-release-6.5
Dec 20, 2022
Merged

ddl: fix waiting for wrong schema version if TiDB server restart (#39985)#40056
ti-chi-bot merged 6 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-39985-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 20, 2022

This is an automated cherry-pick of #39985

Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com

What problem does this PR solve?

Issue Number: close #39981

Problem Summary:
As described in the issue.

What is changed and how it works?

Handle the case that MDL is enabled separately. Only need to wait for getting the metadata lock.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@wjhuang2016 @ti-chi-bot
done
d0426c0 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016 @ti-chi-bot
done
6f392fb 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 20, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Dec 20, 2022
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Dec 20, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 20, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 20, 2022
@xiongjiwei
Copy link
Contributor

xiongjiwei commented Dec 20, 2022

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Dec 20, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 6f392fb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 20, 2022
@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 20, 2022
@wjhuang2016
Copy link
Member

wjhuang2016 commented Dec 20, 2022

/merge

@wjhuang2016
Copy link
Member

wjhuang2016 commented Dec 20, 2022

/run-check_dev_2

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Dec 20, 2022

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 4c53df4 into pingcap:release-6.5 Dec 20, 2022
@ti-chi-bot ti-chi-bot deleted the cherry-pick-39985-to-release-6.5 branch April 15, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tangenta tangenta tangenta approved these changes

+1 more reviewer

@xiongjiwei xiongjiwei xiongjiwei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wjhuang2016 wjhuang2016

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ti-chi-bot @xiongjiwei @wjhuang2016 @tangenta @sre-bot @hawkingrei