Skip to content

planner: fix pessimistic-auto-commit not working for point plans (#39993)#40000

Merged
ti-chi-bot merged 3 commits intopingcap:release-6.1from
ti-chi-bot:cherry-pick-39993-to-release-6.1
Jan 18, 2023
Merged

planner: fix pessimistic-auto-commit not working for point plans (#39993)#40000
ti-chi-bot merged 3 commits intopingcap:release-6.1from
ti-chi-bot:cherry-pick-39993-to-release-6.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 16, 2022

This is an automated cherry-pick of #39993

Signed-off-by: zyguan zhongyangguan@gmail.com

What problem does this PR solve?

Issue Number: close #39928

Problem Summary: pessimistic-auto-commit doesn't work for point plans.

What is changed and how it works?

check pessimistic-auto-commit config on building point plans.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@zyguan @ti-chi-bot
planner: fix pessimistic-auto-commit not working for point plans
6fedaac 
Signed-off-by: zyguan <zhongyangguan@gmail.com>
@zyguan @ti-chi-bot
address pingcap#39993 (comment)
bb51874 
Signed-off-by: zyguan <zhongyangguan@gmail.com>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Dec 16, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • MyonKeminta
  • cfzjywxk

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Dec 16, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 16, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Dec 16, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 18, 2023
@MyonKeminta
Copy link
Contributor

MyonKeminta commented Jan 18, 2023

/test unit-test
/test mysql-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 18, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 18, 2023
@cfzjywxk
Copy link
Contributor

cfzjywxk commented Jan 18, 2023

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jan 18, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: bb51874

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 18, 2023
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jan 18, 2023

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@cfzjywxk
Copy link
Contributor

cfzjywxk commented Jan 18, 2023

/retest

3 similar comments
@cfzjywxk
Copy link
Contributor

cfzjywxk commented Jan 18, 2023

/retest

@cfzjywxk
Copy link
Contributor

cfzjywxk commented Jan 18, 2023

/retest

@cfzjywxk
Copy link
Contributor

cfzjywxk commented Jan 18, 2023

/retest

@ti-chi-bot ti-chi-bot merged commit e96bc9b into pingcap:release-6.1 Jan 18, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-39993-to-release-6.1 branch April 15, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@MyonKeminta MyonKeminta MyonKeminta approved these changes

Assignees

@zyguan zyguan

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-chi-bot @MyonKeminta @cfzjywxk @zyguan @VelocityLight