Skip to content

ttl, variables: add system variables for ttl job schedule (#39727)#39869

Merged
ti-chi-bot merged 5 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-39727-to-release-6.5
Dec 20, 2022
Merged

ttl, variables: add system variables for ttl job schedule (#39727)#39869
ti-chi-bot merged 5 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-39727-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 13, 2022

This is an automated cherry-pick of #39727

What problem does this PR solve?

Issue Number: close #39725

Problem Summary:

Add the following system variable for ttl job schedule:

  • tidb_ttl_job_run_interval
  • tidb_ttl_job_schedule_window_start_time
  • tidb_ttl_job_schedule_window_end_time
  • tidb_ttl_scan_worker_count
  • tidb_ttl_delete_worker_count

It also removes the TTLFeatureGate

What is changed and how it works?

These global variables (except worker counts) are all tracked by an atomic variable, and set/get through the hook. The scan/delete worker count are set/get through scaling the workers in the ttl job manager.

This PR is based on #39472

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Add system variables `tidb_ttl_job_run_interval`, `tidb_ttl_job_schedule_window_start_time`, `tidb_ttl_job_schedule_window_end_time`, `tidb_ttl_scan_worker_count`, `tidb_ttl_delete_worker_count` to control the ttl job management

@ti-chi-bot ti-chi-bot requested a review from a team as a code owner December 13, 2022 06:29
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Dec 13, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YangKeao
  • bb7133

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Dec 13, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 13, 2022
Merged
4 tasks
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 13, 2022
@YangKeao YangKeao mentioned this pull request Dec 16, 2022
Closed
60 tasks
@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 19, 2022
@YangKeao YangKeao force-pushed the cherry-pick-39727-to-release-6.5 branch from f0bae26 to 73e519b Compare December 20, 2022 05:37
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 20, 2022
YangKeao
YangKeao approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 20, 2022
@YangKeao
Copy link
Member

YangKeao commented Dec 20, 2022

/run-check_dev_2

@YangKeao
Copy link
Member

YangKeao commented Dec 20, 2022

/run-build

bb7133
bb7133 approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 20, 2022
@YangKeao
Copy link
Member

YangKeao commented Dec 20, 2022

/run-unit-test

@YangKeao
Copy link
Member

YangKeao commented Dec 20, 2022

Oops. To pass the unit-test, it requires #39767

@hawkingrei
Copy link
Member

hawkingrei commented Dec 20, 2022

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Dec 20, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 73e519b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 20, 2022
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Dec 20, 2022

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 928f6da into pingcap:release-6.5 Dec 20, 2022
@ti-chi-bot ti-chi-bot deleted the cherry-pick-39727-to-release-6.5 branch April 15, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 bb7133 approved these changes

@YangKeao YangKeao YangKeao approved these changes

Assignees

No one assigned

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-chi-bot @YangKeao @hawkingrei @bb7133 @sre-bot