Skip to content

import: fix dup-detect failure on index data#39571

Merged
ti-chi-bot merged 4 commits intopingcap:masterfrom
dsdashun:fix-39476
Dec 2, 2022
Merged

import: fix dup-detect failure on index data#39571
ti-chi-bot merged 4 commits intopingcap:masterfrom
dsdashun:fix-39476

Conversation

@dsdashun
Copy link
Contributor

@dsdashun dsdashun commented Dec 2, 2022

What problem does this PR solve?

Issue Number: close #39476

Problem Summary:

What is changed and how it works?

Pass the index info when constructing a dup-detect task for index data. Otherwise the task will be treated as a record data dup-detect task.

Check List

Tests

  • Unit test
  • Integration test (covered in lightning_duplicate_detection)
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 2, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • Ehco1996

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 2, 2022
@dsdashun
Copy link
Contributor Author

dsdashun commented Dec 2, 2022

/run-integration-br-test

Ehco1996
Ehco1996 approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@Ehco1996 Ehco1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after seen this #39476 (comment)

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 2, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 2, 2022
@dsdashun
Copy link
Contributor Author

dsdashun commented Dec 2, 2022

Integration BR test failed at br_foreign_key. All Lightning integration tests have passed:
https://ci.pingcap.net/blue/organizations/jenkins/br_ghpr_unit_and_integration_test/detail/br_ghpr_unit_and_integration_test/14283/pipeline

@dsdashun
Copy link
Contributor Author

dsdashun commented Dec 2, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 2, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 49f6045

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 2, 2022
@ti-chi-bot ti-chi-bot merged commit eed9ceb into pingcap:master Dec 2, 2022
@dsdashun dsdashun deleted the fix-39476 branch December 2, 2022 03:41
@sre-bot
Copy link
Contributor

sre-bot commented Dec 2, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [2] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/sqllogic-test-2 🟥 failed 1, success 27, total 28 6 min 1 sec New failing
idc-jenkins-ci-tidb/sqllogic-test-1 🟥 failed 1, success 25, total 26 5 min 5 sec New failing
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 39, total 40 25 min Existing failure
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 2, success 15, total 17 22 min Existing failure
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 11 min Existing failure
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 12 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 4 min 30 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 54 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@D3Hunter D3Hunter D3Hunter approved these changes

+1 more reviewer

@Ehco1996 Ehco1996 Ehco1996 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

lightning parallel import single table with duplication data fail when duplicate-resolution = record

5 participants

@dsdashun @ti-chi-bot @sre-bot @D3Hunter @Ehco1996