parser: supports create/alter/drop resource group#39546
parser: supports create/alter/drop resource group#39546ti-chi-bot merged 8 commits intopingcap:masterfrom
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
Signed-off-by: nolouch <nolouch@gmail.com>
f98f2f4 to
34c1ed2
Compare
Signed-off-by: nolouch <nolouch@gmail.com>
Conflicts: parser/parser.go
tiancaiamao
left a comment
There was a problem hiding this comment.
What does OR REPLACE
Signed-off-by: nolouch <nolouch@gmail.com>
Conflicts: parser/parser.go
| { | ||
| $$ = &ast.ResourceGroupOption{Tp: ast.ResourceWRURate, StrValue: $3} | ||
| } | ||
| | "CPU" EqOpt stringLit |
There was a problem hiding this comment.
So, we can say "create resource group x rru_per_sec='2000', cpu = '8'". That is specify rru_per_sec and cpu at the same time? The semantic is a little weird. I prefer to make 2 option groups, either rru&wru or cpu/iobandwidth.
There was a problem hiding this comment.
Here only parser part. we can limit the behavior in DDL handle logic. ru and cpu/bandwith cannot be specified at the same time, report the error to user.
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: b9c897f |
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
Signed-off-by: nolouch nolouch@gmail.com
What problem does this PR solve?
Issue Number: Ref #38825
Problem Summary:
The Spec show details: https://docs.google.com/document/d/1P_D1R1qGMFjmjbGCxYjRodgp1Yeyx4dBvg2W1l_Eiy0/edit?n=1-page_Spec_template#
What is changed and how it works?
add parser part only.
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.