Skip to content

error: print non-printable chars in hex style for duplicate entry error#39485

Merged
ti-chi-bot merged 38 commits intopingcap:masterfrom
winkyao:master
Dec 1, 2022
Merged

error: print non-printable chars in hex style for duplicate entry error#39485
ti-chi-bot merged 38 commits intopingcap:masterfrom
winkyao:master

Conversation

@winkyao
Copy link
Contributor

@winkyao winkyao commented Nov 30, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #35289

  • Integration test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

winkyao and others added 13 commits November 28, 2022 14:36
@winkyao
session: remove useless parser object in SessionHandle of bindinfo pa…
03ce121 
…ckage
@winkyao
Merge branch 'master' into master
4305e94
@winkyao
session: change parser.New to get a parser from pool
68eecc2
@winkyao
Merge branch 'master' of github.com:winkyao/tidb
9bf7765
@winkyao
Revert "session: change parser.New to get a parser from pool"
829a337 
This reverts commit 68eecc2.
@crazycs520
Merge branch 'master' into master
a8dfda7
@ti-chi-bot
Merge branch 'master' into master
9dad1ba
@winkyao
session: change parser.New to get a parser from pool
170ed4c
@winkyao
Revert "session: change parser.New to get a parser from pool"
e76538f 
This reverts commit 68eecc2.
@winkyao
error: fix #35289, turn non-printable chars in Duplicate entry error …
5a58471 
…message into hex
@winkyao
Merge remote-tracking branch 'upstream/master'
a487c12
@winkyao
add unit test
9cec937
@winkyao
Merge branch 'master' of github.com:winkyao/tidb
d4101fb
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 30, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 30, 2022
@tangenta tangenta changed the title error: fix #35289, turn non-printable chars in Duplicate entry error message into hex error: print non-printable chars in hex style for duplicate entry error Nov 30, 2022
@winkyao
Copy link
Contributor Author

winkyao commented Nov 30, 2022

/run-build

tangenta
tangenta reviewed Nov 30, 2022
View reviewed changes
@winkyao
Copy link
Contributor Author

winkyao commented Nov 30, 2022

@tangenta Addressed, PTAL

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 30, 2022
hawkingrei
hawkingrei reviewed Nov 30, 2022
View reviewed changes
expression/integration_test.go Outdated
tk.MustQuery(`select str_to_date(substr(dest,1,6),'%H%i%s') from sun;`).Check(testkit.Rows("20:23:10"))
}

func TestIssue35289(t *testing.T) {
Copy link
Member

@hawkingrei hawkingrei Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestIssue35289 is a bad name of test cases. we should avoid it.

I think it is a corner case about insert and we can put it into TestInsert and comment the issue id.

@winkyao winkyao added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2022
@winkyao
Copy link
Contributor Author

winkyao commented Nov 30, 2022

/run-mysql-test tidb-test=pr/2028

@crazycs520
Copy link
Contributor

crazycs520 commented Dec 1, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 1, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: aa406ed

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 1, 2022
@crazycs520
Copy link
Contributor

crazycs520 commented Dec 1, 2022

/run-mysql-test tidb-test=pr/2028

1 similar comment
@winkyao
Copy link
Contributor Author

winkyao commented Dec 1, 2022

/run-mysql-test tidb-test=pr/2028

@hawkingrei
Copy link
Member

hawkingrei commented Dec 1, 2022

/run-mysql-test tidb-test=pr/2028

@winkyao
Copy link
Contributor Author

winkyao commented Dec 1, 2022

/run-mysql-test tidb-test=pr/2028

@crazycs520
Copy link
Contributor

crazycs520 commented Dec 1, 2022

/run-mysql-test tidb-test=pr/2028

@crazycs520
Copy link
Contributor

crazycs520 commented Dec 1, 2022

/merge

@crazycs520
Copy link
Contributor

crazycs520 commented Dec 1, 2022

/run-mysql-test tidb-test=pr/2028

@crazycs520
Copy link
Contributor

crazycs520 commented Dec 1, 2022

/merge

@winkyao
Copy link
Contributor Author

winkyao commented Dec 1, 2022

/run-mysql-test

@winkyao
Copy link
Contributor Author

winkyao commented Dec 1, 2022

/run-build

@ti-chi-bot ti-chi-bot merged commit 94ffc8e into pingcap:master Dec 1, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Dec 1, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [2] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 1, success 16, total 17 12 min New failing
idc-jenkins-ci-tidb/common-test 🟥 failed 1, success 10, total 11 11 min New failing
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 39, total 40 24 min Existing failure
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 47 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 37 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 18 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 7 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 28 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 16 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@winkyao winkyao mentioned this pull request Dec 1, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@tangenta tangenta tangenta approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error message of duplicate primary key is not shown properly

6 participants

@winkyao @ti-chi-bot @crazycs520 @hawkingrei @sre-bot @tangenta