Skip to content

*: add telemetry support for IndexMerge#39469

Merged
ti-chi-bot merged 6 commits intopingcap:masterfrom
guo-shaoge:telemetry_index_merge
Nov 30, 2022
Merged

*: add telemetry support for IndexMerge#39469
ti-chi-bot merged 6 commits intopingcap:masterfrom
guo-shaoge:telemetry_index_merge

Conversation

@guo-shaoge
Copy link
Collaborator

@guo-shaoge guo-shaoge commented Nov 29, 2022 •
edited
Loading

Signed-off-by: guo-shaoge shaoge1994@163.com

What problem does this PR solve?

Issue Number: close #39475

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 29, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 29, 2022
@guo-shaoge
*: add telemetry support for IndexMerge
416d359 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 30, 2022
@guo-shaoge
Merge branch 'master' of github.com:pingcap/tidb into telemetry_index…
09d54af 
…_merge

Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
fix case
4329a5d 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
fix
58cf46b 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
Merge branch 'master' into telemetry_index_merge
252464e
@guo-shaoge
Copy link
Collaborator Author

guo-shaoge commented Nov 30, 2022

/run-mysql-test

@guo-shaoge
Copy link
Collaborator Author

guo-shaoge commented Nov 30, 2022

/run-check_dev_2

1 similar comment
@guo-shaoge
Copy link
Collaborator Author

guo-shaoge commented Nov 30, 2022

/run-check_dev_2

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 30, 2022

@AstroProfundis: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

lucklove
lucklove approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 30, 2022

@lucklove: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 30, 2022
@guo-shaoge
Copy link
Collaborator Author

guo-shaoge commented Nov 30, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 30, 2022
@guo-shaoge
Copy link
Collaborator Author

guo-shaoge commented Nov 30, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 30, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 252464e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2022
@ti-chi-bot ti-chi-bot merged commit e98e959 into pingcap:master Nov 30, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Nov 30, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 1, success 16, total 17 19 min New failing
idc-jenkins-ci/integration-cdc-test ✅ all 40 tests passed 23 min Fixed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 34 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 6 min 16 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 55 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 14 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 16 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 27 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

+2 more reviewers

@AstroProfundis AstroProfundis AstroProfundis approved these changes

@lucklove lucklove lucklove approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add telemetry support for IndexMerge

7 participants

@guo-shaoge @ti-chi-bot @sre-bot @AstroProfundis @lucklove @XuHuaiyu @time-and-fate