Skip to content

telemetry: add telemetry for alter table compact partition#39452

Merged
ti-chi-bot merged 3 commits intopingcap:masterfrom
hehechen:telemetry
Nov 29, 2022
Merged

telemetry: add telemetry for alter table compact partition#39452
ti-chi-bot merged 3 commits intopingcap:masterfrom
hehechen:telemetry

Conversation

@hehechen
Copy link
Contributor

@hehechen hehechen commented Nov 29, 2022

Signed-off-by: hehechen chentongli@pingcap.com

What problem does this PR solve?

Issue Number: ref #36175

Problem Summary:

What is changed and how it works?

Add telemetry for ALTER TABLE [name] COMPACT PARTITION [PartitionNameList] TIFLASH REPLICA.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

add telemetry for alter table compact partition
08d15af 
Signed-off-by: hehechen <chentongli@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 29, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 29, 2022
@hehechen
Copy link
Contributor Author

hehechen commented Nov 29, 2022

/cc @breezewish @windtalker

@hehechen
Copy link
Contributor Author

hehechen commented Nov 29, 2022

/cc @AstroProfundis

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 29, 2022
@hehechen
Copy link
Contributor Author

hehechen commented Nov 29, 2022

/cc @lucklove

@ti-chi-bot ti-chi-bot requested a review from lucklove November 29, 2022 09:21
windtalker
windtalker approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 29, 2022
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 29, 2022
@hawkingrei
Copy link
Member

hawkingrei commented Nov 29, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 29, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 87b33aa

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 29, 2022
lucklove
lucklove approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 29, 2022

@lucklove: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hehechen
Copy link
Contributor Author

hehechen commented Nov 29, 2022

/assign @breezewish

@hehechen
Copy link
Contributor Author

hehechen commented Nov 29, 2022

/run-all-tests

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 29, 2022

@AstroProfundis: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hehechen
Copy link
Contributor Author

hehechen commented Nov 29, 2022

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 1b15732 into pingcap:master Nov 29, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Nov 29, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test ✅ all 6 tests passed 8 min 11 sec Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 40 tests passed 23 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 22 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 7 min 31 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 7 min 11 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 6 min 51 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 56 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 51 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@breezewish breezewish breezewish approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@lance6716 lance6716 Awaiting requested review from lance6716

@windtalker windtalker Awaiting requested review from windtalker

@crazycs520 crazycs520 Awaiting requested review from crazycs520

+2 more reviewers

@AstroProfundis AstroProfundis AstroProfundis approved these changes

@lucklove lucklove lucklove approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@breezewish breezewish

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@hehechen @ti-chi-bot @hawkingrei @sre-bot @AstroProfundis @windtalker @breezewish @lucklove