*: improve flashback to timestamp, let it compatible with TiCDC#39442
*: improve flashback to timestamp, let it compatible with TiCDC#39442ti-chi-bot merged 9 commits intopingcap:masterfrom
flashback to timestamp, let it compatible with TiCDC#39442Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
flashback to timestamp, let it compatible with TiCDC
fengou1
left a comment
There was a problem hiding this comment.
for backup restore:
flashback version = resolvedTs
startTs = restoreTs - 1
commitTs = restoreTs
| } | ||
|
|
||
| if err := recovery.PrepareFlashbackToVersion(ctx); err != nil { | ||
| if err := recovery.PrepareFlashbackToVersion(ctx, resolveTS, restoreTS-1); err != nil { |
There was a problem hiding this comment.
Can we guarantee that no other write on restoreTS-1? Otherwise, it may overwrite the old value.
/cc @fengou1
There was a problem hiding this comment.
Yes, In EBS restore. workflow as follows
- start pd
- set pd/tikv recoverymode
- start tikv
- prepare/flashback version
- start tidb
there is no chance to write any data before step 5 (start tidb)
|
/hold |
|
merge it after tikv/tikv#13823 merged |
|
/unhold |
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 8ee78c6 |
TiDB MergeCI notify✅ Well Done! New fixed [1] after this pr merged.
|
What problem does this PR solve?
Issue Number: ref tikv/tikv#13823
Problem Summary:
startTSandflashbackTSin prepare phase, let it compatible with TiCDC.pd scheduleparams.What is changed and how it works?
Check List
Tests
use the tikv-server with server, storage: make flashback compatible with resolved_ts tikv/tikv#13823 patch. It works well.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.