parser: use alter table remove ttl spec#39341
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
108a90a to
cd6fe00
Compare
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
cd6fe00 to
885cfa5
Compare
|
@lcwangchao @hawkingrei Could you help me to merge this PR? |
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 9cc5dc0 |
TiDB MergeCI notify✅ Well Done! New fixed [1] after this pr merged.
|
Signed-off-by: YangKeao yangkeao@chunibyo.icu
What problem does this PR solve?
Issue Number: close #39340
Problem Summary:
Use
alter table remove ttlinstead ofalter table no_ttl. And remove the support of arbitrary expression, but only support valueExpr from Literal.What is changed and how it works?
It changed three things:
AlterTablePartitionOpttoAlterTableSingleSpecOptand add a"REMOVE" "TTL"branch to it. We cannot add"REMOVE" "TTL"to other rules orAlterTableSpecbecauseyacchas to know whether to reduce theAlterTableSpecand moving forward toAlterTablePartitionOpt, or try to"REMOVE" "TTL"valueExpr. Maybe we could modify it toDefaultValueExpror other wider range grammar later, but supporing number / string literal is enough for today.Check List
Tests
Release note