Skip to content

dumpling: fix TestSpeedRecorder flaky test#39314

Merged
ti-chi-bot merged 1 commit intopingcap:masterfrom
okJiang:fix-flaky-39255
Nov 22, 2022
Merged

dumpling: fix TestSpeedRecorder flaky test#39314
ti-chi-bot merged 1 commit intopingcap:masterfrom
okJiang:fix-flaky-39255

Conversation

@okJiang
Copy link
Member

@okJiang okJiang commented Nov 22, 2022

What problem does this PR solve?

Issue Number: close #39255

Problem Summary:

What is changed and how it works?

increased error tolerance

Check List

Tests

  • Unit test

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 22, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 22, 2022
@okJiang okJiang added the component/dumpling This is related to Dumpling of TiDB. label Nov 22, 2022
@okJiang
Copy link
Member Author

okJiang commented Nov 22, 2022

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 22, 2022
@okJiang
Copy link
Member Author

okJiang commented Nov 22, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 22, 2022

@okJiang: /merge in this pull request requires 2 approval(s).

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hawkingrei hawkingrei requested a review from lance6716 November 22, 2022 09:47
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 22, 2022
@lance6716
Copy link
Contributor

lance6716 commented Nov 22, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 22, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 1229dd6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 22, 2022
@ti-chi-bot ti-chi-bot merged commit d5e9ef0 into pingcap:master Nov 22, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Nov 22, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟥 failed 1, success 38, total 39 21 min New failing
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 11 min Existing failure
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 25 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 8 min 2 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 7 min 44 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 52 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 27 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 2 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lance6716 lance6716 lance6716 approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees

No one assigned

Labels

component/dumpling This is related to Dumpling of TiDB. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flaky test in the TestSpeedRecorder

5 participants

@okJiang @ti-chi-bot @lance6716 @sre-bot @hawkingrei