Skip to content

*: fix tidb_decode_key with partition table#39312

Merged
ti-chi-bot merged 9 commits intopingcap:masterfrom
Defined2014:fix-39304
Nov 22, 2022
Merged

*: fix tidb_decode_key with partition table#39312
ti-chi-bot merged 9 commits intopingcap:masterfrom
Defined2014:fix-39304

Conversation

@Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Nov 22, 2022

What problem does this PR solve?

Issue Number: close #39304

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 22, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 22, 2022
@Defined2014 Defined2014 changed the title *: fix tidb_decode_key deal with partition table *: fix tidb_decode_key with partition table Nov 22, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 22, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 22, 2022
@tangenta
Copy link
Contributor

tangenta commented Nov 22, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 22, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 95c0e0c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 22, 2022
@hawkingrei
Copy link
Member

hawkingrei commented Nov 22, 2022

/run-all-tests

@Defined2014
Copy link
Contributor Author

Defined2014 commented Nov 22, 2022

/run-mysql-test

@hawkingrei
Copy link
Member

hawkingrei commented Nov 22, 2022

/run-unit-test

@Defined2014
Copy link
Contributor Author

Defined2014 commented Nov 22, 2022

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 8fc4535 into pingcap:master Nov 22, 2022
@Defined2014 Defined2014 deleted the fix-39304 branch November 22, 2022 13:10
@sre-bot
Copy link
Contributor

sre-bot commented Nov 22, 2022

TiDB MergeCI notify

🔴 Bad News! [1] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 11 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 39 tests passed 19 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 9 min 48 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 56 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 4 min 25 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 3 min 56 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 3 min 45 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 55 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@tangenta tangenta tangenta approved these changes

@mjonss mjonss Awaiting requested review from mjonss

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TIDB_DECODE_KEY use partition id instead of table id

5 participants

@Defined2014 @ti-chi-bot @tangenta @hawkingrei @sre-bot