Skip to content

ddl: forbid disabling concurrent DDL if MDL is enabled#39301

Merged
ti-chi-bot merged 7 commits intopingcap:masterfrom
wjhuang2016:add_concurrent_ddl_mdl_comp
Nov 22, 2022
Merged

ddl: forbid disabling concurrent DDL if MDL is enabled#39301
ti-chi-bot merged 7 commits intopingcap:masterfrom
wjhuang2016:add_concurrent_ddl_mdl_comp

Conversation

@wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Nov 21, 2022 •
edited
Loading

Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com

What problem does this PR solve?

Issue Number: close #39131

forbid disabling concurrent DDL if MDL is enabled

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@wjhuang2016
refine
568ae05 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 21, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Benjamin2037
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 21, 2022
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Nov 22, 2022

/run-unit-test

@wjhuang2016
fix test
750bd9a 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
try
db735d6 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
Copy link
Member Author

wjhuang2016 commented Nov 22, 2022

/run-check_dev

@wjhuang2016
fix bazel
6e22f76 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
Benjamin2037
Benjamin2037 reviewed Nov 22, 2022
View reviewed changes
Benjamin2037
Benjamin2037 reviewed Nov 22, 2022
View reviewed changes
Benjamin2037
Benjamin2037 reviewed Nov 22, 2022
View reviewed changes
Benjamin2037
Benjamin2037 reviewed Nov 22, 2022
View reviewed changes
ddl/ddl.go
}

if variable.EnableMDL.Load() && !toConcurrentDDL {
return errors.New("can not disable concurrent ddl when metadata lock is enabled")
Copy link
Collaborator

@Benjamin2037 Benjamin2037 Nov 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a place to collect all error msg?

Copy link
Member Author

@wjhuang2016 wjhuang2016 Nov 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For standard error with the error code, yes. For these misc errors, no.

Copy link
Contributor

@tangenta tangenta Nov 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to have an error code for each TiDB specific feature.

@Benjamin2037 Benjamin2037 self-requested a review November 22, 2022 09:07
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 22, 2022
Benjamin2037
Benjamin2037 approved these changes Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 22, 2022
@wjhuang2016
Copy link
Member Author

wjhuang2016 commented Nov 22, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 22, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 6e22f76

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 22, 2022
@ti-chi-bot ti-chi-bot merged commit 75efe68 into pingcap:master Nov 22, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Nov 22, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🔴 failed 2, success 37, total 39 20 min Existing failure
idc-jenkins-ci-tidb/mybatis-test ✅ all 1 tests passed 5 min 12 sec Fixed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 16 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 9 min 58 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 13 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 2 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 2 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 32 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 14 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@tangenta tangenta tangenta approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ddl blocked when the tidb_enable_concurrent_ddl is set to off

7 participants

@wjhuang2016 @ti-chi-bot @wuhuizuo @sre-bot @Benjamin2037 @tangenta @hawkingrei