ddl: support read records with copr for adding index by tangenta · Pull Request #39191 · pingcap/tidb

tangenta · 2022-11-16T08:35:52Z

What problem does this PR solve?

Issue Number: ref #35983

Problem Summary:

What is changed and how it works?

This PR supports using coprocessor to read the table records for adding index.

Check List

Tests

The test is covered by realtikvtest/addindex.

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ti-chi-bot · 2022-11-16T08:35:55Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

Defined2014
wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Defined2014

Could you add a performance report in release note?

ddl/index_cop.go

Defined2014 · 2022-11-17T08:38:28Z

ddl/index_cop.go

+	return copCtx
+}
+
+func (c *copContext) buildTableScan(ctx context.Context, startTS uint64, start, end kv.Key) (distsql.SelectResult, error) {


It looks very like

tidb/ddl/reorg.go

Line 438 in 706a646

func (dc *ddlCtx) buildDescTableScan(ctx *JobContext, startTS uint64, tbl table.PhysicalTable,

, could we combine those two functions?

Sure, let's clean these up in another PR.

There are similar code in the following places:

(dc *ddlCtx) buildDescTableScan

(e *CheckIndexRangeExec) Open

(e *RecoverIndexExec) buildTableScan

(e *CleanupIndexExec) buildIndexScan

tangenta · 2022-11-17T08:57:12Z

Could you add a performance report in release note?

The performance gets a little bit worse and unstable than the previous implementation, because this PR builds & sends the coprocessor requests multiple times for the same task range.

I would like to post the performance report in the next PR, which reuses the same coprocessor request and makes read and write asynchronize.

Benjamin2037 · 2022-11-18T06:58:03Z

tangenta · 2022-11-18T07:28:03Z

/hold

hawkingrei · 2022-11-18T09:54:45Z

ddl/index_cop_test.go

+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package ddl_test


Can we create a new folder to put this test case? DDL put too much test cases in the folder.

What is the problem?

Benjamin2037

LGTM

tangenta · 2022-11-18T11:23:27Z

/unhold

tangenta · 2022-11-18T11:50:05Z

/merge

ti-chi-bot · 2022-11-18T11:50:09Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: abdf626

sre-bot · 2022-11-18T12:16:31Z

TiDB MergeCI notify

🔴 Bad News! [2] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name	Result	Duration	Compare with Parent commit
idc-jenkins-ci/integration-cdc-test	🔴 failed 1, success 38, total 39	19 min	Existing failure
idc-jenkins-ci-tidb/mybatis-test	🔴 failed 1, success 0, total 1	11 min	Existing failure
idc-jenkins-ci-tidb/integration-common-test	🟢 all 17 tests passed	10 min	Existing passed
idc-jenkins-ci-tidb/common-test	🟢 all 11 tests passed	9 min 36 sec	Existing passed
idc-jenkins-ci-tidb/tics-test	🟢 all 1 tests passed	6 min 15 sec	Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2	🟢 all 28 tests passed	5 min 4 sec	Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1	🟢 all 26 tests passed	4 min 45 sec	Existing passed
idc-jenkins-ci-tidb/integration-ddl-test	🟢 all 6 tests passed	4 min 27 sec	Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test	🟢 all 1 tests passed	2 min 37 sec	Existing passed
idc-jenkins-ci-tidb/plugin-test	🟢 build success, plugin test success	4min	Existing passed

ddl: support read records with copr for adding index

13929b6

ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 16, 2022

tangenta mentioned this pull request Nov 16, 2022

Improve the performance of adding index #35983

Closed

20 tasks

Benjamin2037 requested review from Benjamin2037 and zimulala November 17, 2022 01:48

tangenta added 5 commits November 17, 2022 10:49

update bazel

4bf61ba

remove unused function

c9dd632

use pkInfo to truncate common handle datum

21e0f77

fix common handle primary key columns

7b281e1

rename coprCtx to copCtx for consistency

7ca5ca3

Defined2014 reviewed Nov 17, 2022

View reviewed changes

ddl/index_cop.go Show resolved Hide resolved

Defined2014 reviewed Nov 17, 2022

View reviewed changes

wjhuang2016 approved these changes Nov 18, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 18, 2022

Defined2014 approved these changes Nov 18, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 18, 2022

add test

e562b0e

ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 18, 2022

tangenta added 2 commits November 18, 2022 14:30

update bazel

28d34f0

Merge branch 'master' into add-index-copr-read

ecd5eba

Benjamin2037 closed this Nov 18, 2022

Benjamin2037 reopened this Nov 18, 2022

ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2022

hawkingrei reviewed Nov 18, 2022

View reviewed changes

fix integration test

abdf626

Benjamin2037 approved these changes Nov 18, 2022

View reviewed changes

ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 18, 2022

ti-chi-bot merged commit e9253f7 into pingcap:master Nov 18, 2022

Defined2014 deleted the add-index-copr-read branch November 18, 2022 12:38

tangenta mentioned this pull request Nov 18, 2022

ddl: make read and write async during adding index #39249

Merged

12 tasks

tangenta mentioned this pull request Nov 23, 2022

ddl: support read generated columns with copr for adding index #39345

Merged

12 tasks

lcwangchao mentioned this pull request Jan 31, 2023

DATA RACE when adding index #40879

Closed

Conversation

tangenta commented Nov 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

Uh oh!

ti-chi-bot commented Nov 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Defined2014 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Defined2014 Nov 17, 2022

Choose a reason for hiding this comment

Uh oh!

tangenta Nov 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tangenta commented Nov 17, 2022

Uh oh!

Benjamin2037 commented Nov 18, 2022

Uh oh!

tangenta commented Nov 18, 2022

Uh oh!

hawkingrei Nov 18, 2022

Choose a reason for hiding this comment

Uh oh!

tangenta Nov 18, 2022

Choose a reason for hiding this comment

Uh oh!

Benjamin2037 left a comment

Choose a reason for hiding this comment

Uh oh!

tangenta commented Nov 18, 2022

Uh oh!

tangenta commented Nov 18, 2022

Uh oh!

ti-chi-bot commented Nov 18, 2022

Uh oh!

sre-bot commented Nov 18, 2022

TiDB MergeCI notify

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

tangenta commented Nov 16, 2022 •

edited

Loading

ti-chi-bot commented Nov 16, 2022 •

edited

Loading

tangenta Nov 17, 2022 •

edited

Loading