Skip to content

dockerfile: use rockylinux#39175

Merged
ti-chi-bot merged 4 commits intopingcap:masterfrom
hawkingrei:upgrade_rocklinux
Nov 16, 2022
Merged

dockerfile: use rockylinux#39175
ti-chi-bot merged 4 commits intopingcap:masterfrom
hawkingrei:upgrade_rocklinux

Conversation

@hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Nov 16, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #38933

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    make docker
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@hawkingrei
dockerfile: use rockylinux
90b9bd8 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
dockerfile: use rockylinux
968b53a 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 16, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 16, 2022
Defined2014
Defined2014 reviewed Nov 16, 2022
View reviewed changes
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 16, 2022
xhebox
xhebox reviewed Nov 16, 2022
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but one thing, releasing is not using this file. I don't think changing this makes any difference other than using glibc.

@hawkingrei
dockerfile: use rockylinux
4d04a0f 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
Copy link
Member Author

hawkingrei commented Nov 16, 2022

LGTM, but one thing, releasing is not using this file. I don't think changing this makes any difference other than using glibc.

I agree with you. But it might be some compliance issue.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 16, 2022
@xhebox
Copy link
Contributor

xhebox commented Nov 16, 2022

LGTM, but one thing, releasing is not using this file. I don't think changing this makes any difference other than using glibc.

I agree with you. But it might be some compliance issue.

Clearly, that is not a problem. Because I am using musl. If there is any problem, I will fix it. 😄

And, go does not have much left problems on musl libc. Talking about containers for go programs, alpine is the best choice.

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 16, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 4d04a0f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 16, 2022
@ti-chi-bot ti-chi-bot merged commit d00c588 into pingcap:master Nov 16, 2022
@hawkingrei hawkingrei deleted the upgrade_rocklinux branch November 16, 2022 05:59
@sre-bot
Copy link
Contributor

sre-bot commented Nov 16, 2022

TiDB MergeCI notify

🔴 Bad News! [3] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 1, success 5, total 6 46 min Existing failure
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 38, total 39 20 min Existing failure
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 11 min Existing failure
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 18 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 15 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 49 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 40 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 2 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhebox xhebox xhebox approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

use rockylinux as base image

5 participants

@hawkingrei @ti-chi-bot @xhebox @sre-bot @Defined2014