*: support password reuse policy by bob34007 · Pull Request #39162 · pingcap/tidb

bob34007 · 2022-11-15T09:44:52Z

What problem does this PR solve?

Issue Number: ref #38937

Problem Summary:

What is changed and how it works?

the feature is the same as MySQL's .

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

 support password reuse policy like MySQL .

modified: errno/errname.go modified: executor/errors.go modified: executor/simple.go

modified: executor/simple_test.go modified: session/bootstrap.go

modified: simple.go modified: simple_test.go modified: ../server/http_handler_serial_test.go modified: ../session/bootstrap.go modified: ../session/bootstrap_test.go modified: ../sessionctx/variable/tidb_vars.go

ti-chi-bot · 2022-11-15T09:44:54Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

CbcWestwolf
xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

modified: errno/errname.go modified: executor/errors.go modified: executor/simple.go

modified: executor/simple_test.go modified: session/bootstrap.go

modified: simple.go modified: simple_test.go modified: ../server/http_handler_serial_test.go modified: ../session/bootstrap.go modified: ../session/bootstrap_test.go modified: ../sessionctx/variable/tidb_vars.go

modified: parser/parser.go modified: parser/parser.y

…o enhance_passwd Conflicts: executor/infoschema_cluster_table_test.go executor/simple.go parser/parser.go server/http_handler_serial_test.go session/bootstrap.go

modified: executor/simple.go modified: session/bootstrap.go

modified: session/bootstrap.go

keeplearning20221 · 2022-11-15T11:10:54Z

/cc cbcwestwolf

CbcWestwolf · 2022-11-15T12:38:09Z

Please run make errdoc to pass the check_dev

CbcWestwolf · 2022-11-15T15:11:15Z

/run-unit-test

keeplearning20221 · 2022-11-16T02:01:16Z

Please run make errdoc to pass the check_dev

done

keeplearning20221 · 2022-11-16T03:55:58Z

/cc ljun0712

Conflicts: session/bootstrap.go

…o enhance_passwd

keeplearning20221 · 2022-12-01T10:10:22Z

/run-mysql-test tidb-test=pr/2022

ti-chi-bot · 2022-12-01T10:55:29Z

@lastincisor: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Conflicts: parser/parser.go

keeplearning20221 · 2022-12-01T13:34:29Z

/run-mysql-test tidb-test=pr/2022

keeplearning20221 · 2022-12-01T13:41:58Z

/run-build

keeplearning20221 · 2022-12-01T13:59:40Z

/run-mysql-test tidb-test=pr/2022

keeplearning20221 · 2022-12-01T14:13:52Z

/run-unit-test

bb7133 · 2022-12-01T23:55:37Z

executor/simple.go

+		return nil, err
+	}
+	req := recordSet.NewChunk(nil)
+	err = recordSet.Next(ctx, req)


Please change it to:

var rowsNum int = 0 err = recordSet.Next(ctx, req) if err == nil { rowsNum = req.NumRows() }

So that handle of err is obvious.

executor/simple.go

Co-authored-by: bb7133 <bb7133@gmail.com>

…o enhance_passwd

keeplearning20221 · 2022-12-02T01:22:51Z

/run-mysql-test tidb-test=pr/2022

modified: executor/simple.go modified: session/bootstrap.go modified: sessionctx/variable/tidb_vars.go

keeplearning20221 · 2022-12-02T01:42:21Z

/run-mysql-test tidb-test=pr/2022

keeplearning20221 · 2022-12-02T01:53:04Z

/run-mysql-test tidb-test=pr/2022

bb7133

LGTM

bb7133 · 2022-12-02T01:57:41Z

/merge

ti-chi-bot · 2022-12-02T01:57:45Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: 53eac1e

sre-bot · 2022-12-02T02:30:18Z

TiDB MergeCI notify

🔴 Bad News! [3] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name	Result	Duration	Compare with Parent commit
idc-jenkins-ci/integration-cdc-test	🔴 failed 1, success 39, total 40	26 min	Existing failure
idc-jenkins-ci-tidb/integration-common-test	🔴 failed 3, success 14, total 17	19 min	Existing failure
idc-jenkins-ci-tidb/common-test	🔴 failed 1, success 10, total 11	10 min	Existing failure
idc-jenkins-ci-tidb/tics-test	🟢 all 1 tests passed	6 min 41 sec	Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2	🟢 all 28 tests passed	6 min 32 sec	Existing passed
idc-jenkins-ci-tidb/integration-ddl-test	🟢 all 6 tests passed	5 min 29 sec	Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1	🟢 all 26 tests passed	4 min 3 sec	Existing passed
idc-jenkins-ci-tidb/mybatis-test	🟢 all 1 tests passed	3 min 54 sec	Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test	🟢 all 1 tests passed	3 min 9 sec	Existing passed
idc-jenkins-ci-tidb/plugin-test	🟢 build success, plugin test success	4min	Existing passed

keeplearning20221 and others added 5 commits November 12, 2022 10:43

Support Password Reuse Policy

7d7c24f

modified: errno/errcode.go

5cb28df

modified: errno/errname.go modified: executor/errors.go modified: executor/simple.go

drop user support

724c6d8

modified: executor/simple.go

fc719ca

modified: executor/simple_test.go modified: session/bootstrap.go

modified: infoschema_cluster_table_test.go

4ce6866

modified: simple.go modified: simple_test.go modified: ../server/http_handler_serial_test.go modified: ../session/bootstrap.go modified: ../session/bootstrap_test.go modified: ../sessionctx/variable/tidb_vars.go

bob34007 requested a review from a team as a code owner November 15, 2022 09:44

ti-chi-bot added do-not-merge/invalid-title release-note-none Denotes a PR that doesn't merit a release note. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 15, 2022

keeplearning20221 and others added 7 commits November 15, 2022 17:56

Support Password Reuse Policy

20ebf62

modified: errno/errcode.go

34140ab

modified: errno/errname.go modified: executor/errors.go modified: executor/simple.go

drop user support

5a7dd17

modified: executor/simple.go

d169f11

modified: executor/simple_test.go modified: session/bootstrap.go

modified: infoschema_cluster_table_test.go

af730b5

modified: simple.go modified: simple_test.go modified: ../server/http_handler_serial_test.go modified: ../session/bootstrap.go modified: ../session/bootstrap_test.go modified: ../sessionctx/variable/tidb_vars.go

modified: executor/simple.go

a988ee6

modified: parser/parser.go modified: parser/parser.y

Merge branch 'enhance_passwd' of https://github.com/bob34007/tidb int…

da04920

…o enhance_passwd Conflicts: executor/infoschema_cluster_table_test.go executor/simple.go parser/parser.go server/http_handler_serial_test.go session/bootstrap.go

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2022

bob34007 changed the title ~~Support Password Reuse Policy~~ *: Support Password Reuse Policy Nov 15, 2022

ti-chi-bot removed the do-not-merge/invalid-title label Nov 15, 2022

keeplearning20221 added 2 commits November 15, 2022 18:42

modified: executor/infoschema_cluster_table_test.go

69d01a4

modified: executor/simple.go modified: session/bootstrap.go

modified: executor/simple_test.go

bf1d0cd

modified: session/bootstrap.go

ti-chi-bot requested a review from CbcWestwolf November 15, 2022 11:10

modified: errors.toml

d3961d6

keeplearning20221 added 2 commits December 1, 2022 17:54

Merge https://github.com/pingcap/tidb into enhance_passwd

419c317

Conflicts: session/bootstrap.go

Merge branch 'enhance_passwd' of https://github.com/bob34007/tidb int…

77a8dee

…o enhance_passwd

lastincisor approved these changes Dec 1, 2022

View reviewed changes

Merge https://github.com/pingcap/tidb into enhance_passwd

bf5161c

Conflicts: parser/parser.go

Merge branch 'master' into enhance_passwd

b2b1c98

bb7133 reviewed Dec 2, 2022

View reviewed changes

Apply suggestions from code review

e8c99a5

Co-authored-by: bb7133 <bb7133@gmail.com>

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2022

keeplearning20221 added 4 commits December 2, 2022 09:15

modified: executor/simple.go

2e0755b

Merge branch 'enhance_passwd' of https://github.com/bob34007/tidb int…

fe71bff

…o enhance_passwd

modified: executor/simple.go

caf6063

resolve conflicts

6f10ebf

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2022

modified: executor/showtest/show_test.go

53eac1e

modified: executor/simple.go modified: session/bootstrap.go modified: sessionctx/variable/tidb_vars.go

bb7133 approved these changes Dec 2, 2022

View reviewed changes

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 2, 2022

ti-chi-bot merged commit 40d1ddb into pingcap:master Dec 2, 2022

CbcWestwolf mentioned this pull request Dec 2, 2022

Support Password Reuse Policy #38937

Closed

Conversation

bob34007 commented Nov 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

Uh oh!

ti-chi-bot commented Nov 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

keeplearning20221 commented Nov 15, 2022

Uh oh!

CbcWestwolf commented Nov 15, 2022

Uh oh!

CbcWestwolf commented Nov 15, 2022

Uh oh!

keeplearning20221 commented Nov 16, 2022

Uh oh!

keeplearning20221 commented Nov 16, 2022

Uh oh!

keeplearning20221 commented Dec 1, 2022

Uh oh!

ti-chi-bot commented Dec 1, 2022

Uh oh!

keeplearning20221 commented Dec 1, 2022

Uh oh!

keeplearning20221 commented Dec 1, 2022

Uh oh!

keeplearning20221 commented Dec 1, 2022

Uh oh!

keeplearning20221 commented Dec 1, 2022

Uh oh!

bb7133 Dec 1, 2022

Choose a reason for hiding this comment

Uh oh!

keeplearning20221 Dec 2, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

keeplearning20221 commented Dec 2, 2022

Uh oh!

keeplearning20221 commented Dec 2, 2022

Uh oh!

keeplearning20221 commented Dec 2, 2022

Uh oh!

bb7133 left a comment

Choose a reason for hiding this comment

Uh oh!

bb7133 commented Dec 2, 2022

Uh oh!

ti-chi-bot commented Dec 2, 2022

Uh oh!

sre-bot commented Dec 2, 2022

TiDB MergeCI notify

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

bob34007 commented Nov 15, 2022 •

edited

Loading

ti-chi-bot commented Nov 15, 2022 •

edited

Loading