Skip to content

domain: support dump plan replayer capture task during query#39125

Merged
ti-chi-bot merged 25 commits intopingcap:masterfrom
Yisaer:support_capture_task
Nov 16, 2022
Merged

domain: support dump plan replayer capture task during query#39125
ti-chi-bot merged 25 commits intopingcap:masterfrom
Yisaer:support_capture_task

Conversation

@Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Nov 14, 2022

What problem does this PR solve?

Issue Number: ref #38779

Problem Summary:

What is changed and how it works?

support dump plan replayer capture task during query

Check List

Tests

  • Unit test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Yisaer added 18 commits November 1, 2022 12:48
@Yisaer
refactor
acdd6d7 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
fix lint
74026c4 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
support
77d9af5 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
Merge remote-tracking branch 'upstream/master' into support_replayer_…
c60cfbe 
…capture
@Yisaer
revise
9d1bc4a 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
add test
2a3c459 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
add test
386f9ab 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
support replayer task
0e86389 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
fix bazel
22f9af2 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
fix liense
eb0bad4 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
Merge remote-tracking branch 'upstream/master' into support_replayer_…
c445b51 
…task
@Yisaer
fix test
21f08b5 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
address the comment
654d2ce 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
refactor
79d92fa 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
support capture task
22a955d 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
Merge remote-tracking branch 'upstream/master' into support_capture_task
d8d7b43
@Yisaer
support
d013a4a 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
support
9ee8a50 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer Yisaer requested a review from a team as a code owner November 14, 2022 06:19
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 14, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 14, 2022
qw4990
qw4990 reviewed Nov 15, 2022
View reviewed changes
executor/compiler.go Outdated
Comment on lines 160 to 169
Copy link
Contributor

@qw4990 qw4990 Nov 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this operation into planner/optimize.go:optimize()? Putting it into the planner package seems more reasonable.

Copy link
Contributor Author

@Yisaer Yisaer Nov 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To build a PlanReplayerDump task with less consuming in query process, we introducing the function inexector, thus we can't move it into planner which would cause cycle import.

qw4990
qw4990 reviewed Nov 15, 2022
View reviewed changes
@Yisaer
fix lint
8f0009e 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer Yisaer force-pushed the support_capture_task branch from cfb154d to 8f0009e Compare November 15, 2022 04:14
@Yisaer
address the comment
8511901 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
fix lint
26d7691 
Signed-off-by: yisaer <disxiaofei@163.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 15, 2022
@Yisaer
fix lint
dcf128d 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer Yisaer force-pushed the support_capture_task branch from ff9a23d to dcf128d Compare November 15, 2022 05:04
@Yisaer
fix test
f75da42 
Signed-off-by: yisaer <disxiaofei@163.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 16, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented Nov 16, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 16, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: f75da42

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 16, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented Nov 16, 2022

/merge

@ti-chi-bot ti-chi-bot merged commit 5aa66cb into pingcap:master Nov 16, 2022
@Yisaer Yisaer deleted the support_capture_task branch November 16, 2022 04:42
@sre-bot
Copy link
Contributor

sre-bot commented Nov 16, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟥 failed 1, success 38, total 39 19 min New failing
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 1, success 5, total 6 44 min Existing failure
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 11 min Existing failure
idc-jenkins-ci-tidb/common-test ✅ all 11 tests passed 9 min 38 sec Fixed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 25 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 9 min 8 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 8 min 29 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 49 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 4 min 18 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@qw4990 qw4990 qw4990 approved these changes

@xuyifangreeneyes xuyifangreeneyes Awaiting requested review from xuyifangreeneyes

@Reminiscent Reminiscent Awaiting requested review from Reminiscent

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Yisaer @ti-chi-bot @sre-bot @hawkingrei @qw4990