planner: update some UTs from cost model1 to model2#39124
Merged
ti-chi-bot merged 8 commits intopingcap:masterfrom Nov 14, 2022
Merged
planner: update some UTs from cost model1 to model2#39124ti-chi-bot merged 8 commits intopingcap:masterfrom
ti-chi-bot merged 8 commits intopingcap:masterfrom
Conversation
Member
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
qw4990
commented
Nov 14, 2022
| "SelectLock 6400.00 root for update 0", | ||
| "└─HashJoin 6400.00 root CARTESIAN inner join, other cond:or(gt(Column#8, 1), or(ne(test.t1.c_str, Column#7), if(ne(Column#9, 0), NULL, 0)))", | ||
| " ├─Selection(Build) 0.80 root ne(Column#10, 0)", | ||
| " │ └─StreamAgg 1.00 root funcs:max(Column#17)->Column#7, funcs:count(distinct Column#18)->Column#8, funcs:sum(Column#19)->Column#9, funcs:count(1)->Column#10", |
Contributor
Author
There was a problem hiding this comment.
Expected, model2 prefers to use HashAgg.
qw4990
commented
Nov 14, 2022
| tk.MustExec("set @@tidb_enable_chunk_rpc = on") | ||
|
|
||
| tk.MustQuery(`explain format=verbose select /*+ TIDB_INLJ(t_outer, t_inner_pk) */ * from t_outer, t_inner_pk where t_outer.a=t_inner_pk.a`).Check(testkit.Rows( // IndexJoin with inner TableScan | ||
| `IndexJoin_11 12487.50 206368.09 root inner join, inner:TableReader_8, outer key:test.t_outer.a, inner key:test.t_inner_pk.a, equal cond:eq(test.t_outer.a, test.t_inner_pk.a)`, |
Contributor
Author
There was a problem hiding this comment.
Expected, just update cost values.
Contributor
Author
|
/run-check_dev_2 |
Reminiscent
approved these changes
Nov 14, 2022
fzzf678
approved these changes
Nov 14, 2022
Contributor
Author
|
/merge |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 2196118 |
Contributor
Author
|
/merge |
Contributor
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #35240
Problem Summary: planner: update some UTs from cost model1 to model2
What is changed and how it works?
planner: update some UTs from cost model1 to model2
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.