Skip to content

binlog: update binlog status from Skippping to On when recover binlog (#32173)#39119

Closed
ti-chi-bot wants to merge 2 commits intopingcap:release-5.2from
ti-chi-bot:cherry-pick-32173-to-release-5.2
Closed

binlog: update binlog status from Skippping to On when recover binlog (#32173)#39119
ti-chi-bot wants to merge 2 commits intopingcap:release-5.2from
ti-chi-bot:cherry-pick-32173-to-release-5.2

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Nov 14, 2022

This is an automated cherry-pick of #32173

Signed-off-by: joccau zak.zhao@pingcap.com

What problem does this PR solve?

Issue Number: close #32172

Problem Summary: As title

What is changed and how it works?

It need to update binlog_status when recover binlog.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

joccau added 2 commits November 14, 2022 03:44
@ti-chi-bot
update binlog status when disable skip binlog
afffd31 
Signed-off-by: joccau <zak.zhao@pingcap.com>
@ti-chi-bot
check returned errno
1457451 
Signed-off-by: joccau <zak.zhao@pingcap.com>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Nov 14, 2022

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved component/binlog size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-5.2 labels Nov 14, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 14, 2022
Merged
12 tasks
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 27, 2023
@ti-chi-bot ti-chi-bot closed this Sep 26, 2023
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Sep 26, 2023

This pull request is closed because its related version has closed automatic cherry-picking.
If it's still needed, you can reopen it or just regenerate it using bot,
see:

https://prow.tidb.net/command-help#cherrypick
https://book.prow.tidb.net/#/plugins/cherrypicker

@ti-chi-bot ti-chi-bot deleted the cherry-pick-32173-to-release-5.2 branch April 15, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joccau joccau

Labels

cherry-pick-approved Cherry pick PR approved by release team. component/binlog release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-5.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @VelocityLight @joccau