Skip to content

binlog: update binlog status from Skippping to On when recover binlog (#32173)#39113

Merged
ti-chi-bot merged 5 commits intopingcap:release-6.1from
ti-chi-bot:cherry-pick-32173-to-release-6.1
Jan 10, 2023
Merged

binlog: update binlog status from Skippping to On when recover binlog (#32173)#39113
ti-chi-bot merged 5 commits intopingcap:release-6.1from
ti-chi-bot:cherry-pick-32173-to-release-6.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Nov 14, 2022

This is an automated cherry-pick of #32173

Signed-off-by: joccau zak.zhao@pingcap.com

What problem does this PR solve?

Issue Number: close #32172

Problem Summary: As title

What is changed and how it works?

It need to update binlog_status when recover binlog.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

joccau added 2 commits November 14, 2022 03:39
@ti-chi-bot
update binlog status when disable skip binlog
e00c5ee 
Signed-off-by: joccau <zak.zhao@pingcap.com>
@ti-chi-bot
check returned errno
613f594 
Signed-off-by: joccau <zak.zhao@pingcap.com>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Nov 14, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • joccau

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Nov 14, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 14, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot added component/binlog size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Nov 14, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Nov 14, 2022
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels Nov 25, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 5, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 10, 2023
joccau
joccau approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@joccau joccau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jan 10, 2023
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 10, 2023
@glorv
Copy link
Contributor

glorv commented Jan 10, 2023

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jan 10, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 299bd61

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 10, 2023
@joccau
Copy link
Contributor

joccau commented Jan 10, 2023

/run-unit-test

@glorv
Copy link
Contributor

glorv commented Jan 10, 2023

/test unit-test

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jan 10, 2023

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 1e39e33 into pingcap:release-6.1 Jan 10, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-32173-to-release-6.1 branch April 15, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glorv glorv glorv approved these changes

+1 more reviewer

@joccau joccau joccau approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@joccau joccau

Labels

cherry-pick-approved Cherry pick PR approved by release team. component/binlog release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @glorv @joccau @VelocityLight