Skip to content

domain: refactor plan replayer implemention#39084

Merged
Yisaer merged 20 commits intopingcap:masterfrom
Yisaer:refactor_replayer_task
Nov 14, 2022
Merged

domain: refactor plan replayer implemention#39084
Yisaer merged 20 commits intopingcap:masterfrom
Yisaer:refactor_replayer_task

Conversation

@Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Nov 11, 2022

What problem does this PR solve?

Issue Number: ref #38779

Problem Summary:

What is changed and how it works?

refactor plan replayer implemention in order to make sctx independent with each compoment and make DumpPlanReplayerInfo can be visited by domain package

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Yisaer added 15 commits November 1, 2022 12:48
@Yisaer
refactor
acdd6d7 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
fix lint
74026c4 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
support
77d9af5 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
Merge remote-tracking branch 'upstream/master' into support_replayer_…
c60cfbe 
…capture
@Yisaer
revise
9d1bc4a 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
add test
2a3c459 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
add test
386f9ab 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
support replayer task
0e86389 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
fix bazel
22f9af2 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
fix liense
eb0bad4 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
Merge remote-tracking branch 'upstream/master' into support_replayer_…
c445b51 
…task
@Yisaer
fix test
21f08b5 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
address the comment
654d2ce 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
refactor
79d92fa 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
support capture task
97d581c 
Signed-off-by: yisaer <disxiaofei@163.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 11, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 11, 2022
@Yisaer Yisaer requested review from hawkingrei and qw4990 November 11, 2022 07:52
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 11, 2022
@Yisaer
fix lint
8fde359 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
fix bazel
7fe4579 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer Yisaer force-pushed the refactor_replayer_task branch from 69b736d to 7fe4579 Compare November 11, 2022 09:41
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 11, 2022
@Yisaer
fix
83cd53a 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer Yisaer force-pushed the refactor_replayer_task branch from fb7f41f to 83cd53a Compare November 11, 2022 15:12
@Yisaer
Copy link
Contributor Author

Yisaer commented Nov 11, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 11, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 83cd53a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 11, 2022
@hawkingrei
Copy link
Member

hawkingrei commented Nov 12, 2022

/hold

@Yisaer Please fix linter

domain/domain.go:1535:67: empty-lines: extra empty line at the end of a block (all_revive)

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2022
@Yisaer
fix
b69e444 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer Yisaer force-pushed the refactor_replayer_task branch from b4ef10e to b69e444 Compare November 14, 2022 02:46
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 14, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented Nov 14, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 14, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: b69e444

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 14, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented Nov 14, 2022

/hold cancel

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2022
@Yisaer Yisaer merged commit 71e66b2 into pingcap:master Nov 14, 2022
@Yisaer Yisaer deleted the refactor_replayer_task branch November 14, 2022 03:13
@sre-bot
Copy link
Contributor

sre-bot commented Nov 14, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 1, success 5, total 6 45 min New failing
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 11 min Existing failure
idc-jenkins-ci/integration-cdc-test ✅ all 39 tests passed 24 min Fixed
idc-jenkins-ci-tidb/integration-common-test ✅ all 17 tests passed 13 min Fixed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 14 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 43 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 33 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 27 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 14 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@qw4990 qw4990 qw4990 approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Yisaer @ti-chi-bot @hawkingrei @sre-bot @qw4990