Skip to content

ddl: refine logic of OwnerCheckAllVersions#39070

Merged
ti-chi-bot merged 3 commits intopingcap:masterfrom
wjhuang2016:refine_checkOwner
Nov 11, 2022
Merged

ddl: refine logic of OwnerCheckAllVersions#39070
ti-chi-bot merged 3 commits intopingcap:masterfrom
wjhuang2016:refine_checkOwner

Conversation

@wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Nov 10, 2022 •
edited
Loading

Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com

What problem does this PR solve?

cluster_info may return invalid TiDB info, in OwnerCheckAllVersions, it doesn't need to check the invalid TiDB info.
If two instances have the same address and port, we know that the one started earlier is invalid.

mysql> select * from information_schema.cluster_info;
+------+---------------------+---------------------+-------------+------------------------------------------+---------------------------+---------------+-----------+
| TYPE | INSTANCE            | STATUS_ADDRESS      | VERSION     | GIT_HASH                                 | START_TIME                | UPTIME        | SERVER_ID |
+------+---------------------+---------------------+-------------+------------------------------------------+---------------------------+---------------+-----------+
| tidb | 192.168.0.102:50002 | 192.168.0.102:28002 | 6.3.0-alpha | 94aa80409637d0f970b917c5ca6cec8876e78fb3 | 2022-11-10T17:01:04+08:00 | 45.575834s    |    724453 |
| tidb | 192.168.0.102:50003 | 192.168.0.102:28003 | 6.3.0-alpha | 94aa80409637d0f970b917c5ca6cec8876e78fb3 | 2022-11-10T17:01:18+08:00 | 31.575837s    |   3596895 |
| tidb | 192.168.0.102:50001 | 192.168.0.102:28001 | 6.3.0-alpha | 94aa80409637d0f970b917c5ca6cec8876e78fb3 | 2022-11-10T17:01:43+08:00 | 6.575845s     |   2636387 |
| tidb | :4000               | :10080              | None        | None                                     | 2022-11-10T17:01:02+08:00 | 47.575848s    |   3272260 |
| tidb | 192.168.0.102:50003 | 192.168.0.102:28003 | 6.3.0-alpha | 94aa80409637d0f970b917c5ca6cec8876e78fb3 | 2022-11-10T17:01:05+08:00 | 44.575849s    |   1515429 |
| tidb | 127.0.0.1:4001      | 127.0.0.1:10081     | 6.3.0-alpha | 94aa80409637d0f970b917c5ca6cec8876e78fb3 | 2022-11-10T16:34:21+08:00 | 27m28.57585s  |     20915 |
| tidb | 127.0.0.1:4000      | 127.0.0.1:10080     | 6.3.0-alpha | 94aa80409637d0f970b917c5ca6cec8876e78fb3 | 2022-11-10T16:34:21+08:00 | 27m28.57585s  |    116956 |
| tidb | 192.168.0.102:50001 | 192.168.0.102:28001 | 6.3.0-alpha | 94aa80409637d0f970b917c5ca6cec8876e78fb3 | 2022-11-10T17:01:02+08:00 | 47.575851s    |    110384 |
| tidb | 192.168.0.102:50001 | 192.168.0.102:28001 | 6.3.0-alpha | 94aa80409637d0f970b917c5ca6cec8876e78fb3 | 2022-11-10T17:01:30+08:00 | 19.575852s    |   1788048 |
| tidb | 127.0.0.1:4002      | 127.0.0.1:10082     | 6.3.0-alpha | 94aa80409637d0f970b917c5ca6cec8876e78fb3 | 2022-11-10T16:34:20+08:00 | 27m29.575853s |   2794409 |
| pd   | 127.0.0.1:2379      | 127.0.0.1:2379      | 6.5.0-alpha | 91f16642cfa3dc53da5aafa481afa63159224aaf | 2022-11-10T16:33:59+08:00 | 27m50.575855s |         0 |
| tikv | 127.0.0.1:20161     | 127.0.0.1:20181     | 6.5.0-alpha | f2e89a4e80e2b99d7ac2abe74d38d4f6eac9ceb6 | 2022-11-10T16:34:03+08:00 | 27m46.575858s |         0 |
| tikv | 127.0.0.1:20162     | 127.0.0.1:20182     | 6.5.0-alpha | f2e89a4e80e2b99d7ac2abe74d38d4f6eac9ceb6 | 2022-11-10T16:34:03+08:00 | 27m46.575859s |         0 |
| tikv | 127.0.0.1:20160     | 127.0.0.1:20180     | 6.5.0-alpha | f2e89a4e80e2b99d7ac2abe74d38d4f6eac9ceb6 | 2022-11-10T16:34:03+08:00 | 27m46.57586s  |         0 |
+------+---------------------+---------------------+-------------+------------------------------------------+---------------------------+---------------+-----------+

What is changed and how it works?

Don't check the invalid TiDB in OwnerCheckAllVersions

Check List

Tests

  • Unit test
  • Integration test
    Pass the intergration_ddl test.
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@wjhuang2016
done
184e7f5 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 10, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lcwangchao
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 10, 2022
@wjhuang2016 wjhuang2016 added the skip-issue-check Indicates that a PR no need to check linked issue. label Nov 10, 2022
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 10, 2022
@wjhuang2016
fix
7407a13 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 11, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 11, 2022
@xhebox
Copy link
Contributor

xhebox commented Nov 11, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 11, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 7407a13

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 11, 2022
@ti-chi-bot ti-chi-bot merged commit a3fff42 into pingcap:master Nov 11, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Nov 11, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 1, success 16, total 17 13 min New failing
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 38, total 39 20 min Existing failure
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 11 min Existing failure
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 2, success 4, total 6 5 min 3 sec Existing failure
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 17 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 7 min 19 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 23 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 10 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 59 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcwangchao lcwangchao lcwangchao approved these changes

@xhebox xhebox xhebox approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wjhuang2016 @ti-chi-bot @xhebox @sre-bot @lcwangchao