Skip to content

executor: fix hashjoin goleak (#39023)#39056

Merged
ti-chi-bot merged 2 commits intopingcap:release-6.1from
ti-chi-bot:cherry-pick-39023-to-release-6.1
Nov 10, 2022
Merged

executor: fix hashjoin goleak (#39023)#39056
ti-chi-bot merged 2 commits intopingcap:release-6.1from
ti-chi-bot:cherry-pick-39023-to-release-6.1

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #39023

Signed-off-by: xhe xw897002528@gmail.com

What problem does this PR solve?

Issue Number: close #39026

Problem Summary: fetchAndBuildHashTable leaked even after rs.Close().

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
make failpoint-enable
go test -run TestRandomPanicConsume -race -v
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 10, 2022
12 tasks
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Nov 10, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Nov 10, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Nov 10, 2022
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox requested review from hawkingrei and wshwsh12 and removed request for wshwsh12 November 10, 2022 07:36
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 10, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 10, 2022
@xhebox
Copy link
Contributor

xhebox commented Nov 10, 2022

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 25ac4a0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 10, 2022
@ti-chi-bot ti-chi-bot merged commit c53ec0f into pingcap:release-6.1 Nov 10, 2022
@ti-chi-bot ti-chi-bot deleted the cherry-pick-39023-to-release-6.1 branch April 15, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants