Skip to content

systable: Adapt with tiflash_tables changes#39001

Merged
ti-chi-bot merged 4 commits intopingcap:masterfrom
JaySon-Huang:adapt_tiflash
Nov 12, 2022
Merged

systable: Adapt with tiflash_tables changes#39001
ti-chi-bot merged 4 commits intopingcap:masterfrom
JaySon-Huang:adapt_tiflash

Conversation

@JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Nov 9, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref pingcap/tiflash#6162

Problem Summary:

In pingcap/tiflash#6175, tiflash adds one new field in informtion_schema.tiflash_tables

  • max_pack_count_in_delta

... and removes the following fields

  • storage_stable_num_pages
  • storage_stable_num_normal_pages
  • storage_stable_max_page_id
  • storage_delta_num_pages
  • storage_delta_num_normal_pages
  • storage_delta_max_page_id
  • storage_meta_num_pages
  • storage_meta_num_normal_pages
  • storage_meta_max_page_id

What is changed and how it works?

Adapt to the changes to tiflash

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
# deploy a tiflash with the changes in https://github.com/pingcap/tiflash/pull/6175
tpcc> select * from information_schema.tiflash_tables where tidb_table = 'order_line' \G
***************************[ 1. row ]***************************
DATABASE                                 | db_70
TABLE                                    | t_145
TIDB_DATABASE                            | tpcc
TIDB_TABLE                               | order_line
TABLE_ID                                 | 145
IS_TOMBSTONE                             | 0
SEGMENT_COUNT                            | 203
TOTAL_ROWS                               | 210607202
TOTAL_SIZE                               | 20007684190
TOTAL_DELETE_RANGES                      | 0
DELTA_RATE_ROWS                          | 0.00545664625467
DELTA_RATE_SEGMENTS                      | 0.586206896552
DELTA_PLACED_RATE                        | 0.781006762042
DELTA_CACHE_SIZE                         | 620065
DELTA_CACHE_RATE                         | 0.00567955872256
DELTA_CACHE_WASTED_RATE                  | 0.0
DELTA_INDEX_SIZE                         | 22607144
AVG_SEGMENT_ROWS                         | 1037473.90148
AVG_SEGMENT_SIZE                         | 98560020.6404
DELTA_COUNT                              | 119
TOTAL_DELTA_ROWS                         | 1149209
TOTAL_DELTA_SIZE                         | 109174855
AVG_DELTA_ROWS                           | 9657.21848739
AVG_DELTA_SIZE                           | 917435.756303
AVG_DELTA_DELETE_RANGES                  | 0.0
STABLE_COUNT                             | 203
TOTAL_STABLE_ROWS                        | 209457993
TOTAL_STABLE_SIZE                        | 19898509335
TOTAL_STABLE_SIZE_ON_DISK                | 8724002804
AVG_STABLE_ROWS                          | 1031812.7734
AVG_STABLE_SIZE                          | 98022213.4729
TOTAL_PACK_COUNT_IN_DELTA                | 893
MAX_PACK_COUNT_IN_DELTA                  | 39
AVG_PACK_COUNT_IN_DELTA                  | 7.50420168067
AVG_PACK_ROWS_IN_DELTA                   | 1286.90817469
AVG_PACK_SIZE_IN_DELTA                   | 122256.276596
TOTAL_PACK_COUNT_IN_STABLE               | 31507
AVG_PACK_COUNT_IN_STABLE                 | 155.206896552
AVG_PACK_ROWS_IN_STABLE                  | 6647.98276573
AVG_PACK_SIZE_IN_STABLE                  | 631558.362745
STORAGE_STABLE_NUM_SNAPSHOTS             | 0
STORAGE_STABLE_OLDEST_SNAPSHOT_LIFETIME  | 0.0
STORAGE_STABLE_OLDEST_SNAPSHOT_THREAD_ID | 0
STORAGE_DELTA_NUM_SNAPSHOTS              | 0
STORAGE_DELTA_OLDEST_SNAPSHOT_LIFETIME   | 0.0
STORAGE_DELTA_OLDEST_SNAPSHOT_THREAD_ID  | 0
STORAGE_META_NUM_SNAPSHOTS               | 0
STORAGE_META_OLDEST_SNAPSHOT_LIFETIME    | 0.0
STORAGE_META_OLDEST_SNAPSHOT_THREAD_ID   | 0
BACKGROUND_TASKS_LENGTH                  | 0
TIFLASH_INSTANCE                         | 172.16.5.85:9540
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 9, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breezewish
  • crazycs520

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 9, 2022
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Nov 9, 2022

/cc @breezewish @lidezhu

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 9, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 9, 2022

@lidezhu: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Nov 9, 2022

/cc @crazycs520 @hawkingrei

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 10, 2022
@hawkingrei
Copy link
Member

hawkingrei commented Nov 12, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 12, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 95d7dda

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 12, 2022
@ti-chi-bot ti-chi-bot merged commit c919985 into pingcap:master Nov 12, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Nov 12, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [2] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 15 min Existing failure
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 11 min Existing failure
idc-jenkins-ci-tidb/integration-common-test ✅ all 17 tests passed 14 min Fixed
idc-jenkins-ci-tidb/integration-ddl-test ✅ all 6 tests passed 5 min 31 sec Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 39 tests passed 20 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 37 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 21 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 40 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 12 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@JaySon-Huang JaySon-Huang deleted the adapt_tiflash branch November 12, 2022 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@breezewish breezewish breezewish approved these changes

@crazycs520 crazycs520 crazycs520 approved these changes

@lidezhu lidezhu lidezhu approved these changes

@hawkingrei hawkingrei Awaiting requested review from hawkingrei

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@JaySon-Huang @ti-chi-bot @hawkingrei @sre-bot @breezewish @crazycs520 @lidezhu