Skip to content

domain: support plan_replayer_status system table#38957

Merged
ti-chi-bot merged 10 commits intopingcap:masterfrom
Yisaer:support_replayer_capture
Nov 10, 2022
Merged

domain: support plan_replayer_status system table#38957
ti-chi-bot merged 10 commits intopingcap:masterfrom
Yisaer:support_replayer_capture

Conversation

@Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Nov 8, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #38779

Problem Summary:

What is changed and how it works?

support plan_replayer_status system table, for now plan replayer handler support :

  1. insert record when dump plan replayer result
  2. delete record when auto gc replan replayer result

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
mysql> plan replayer dump explain select * from t;
+-----------------------------------------------------------+
| File_token                                                |
+-----------------------------------------------------------+
| replayer_GSDmlDgMzsB0kH00JpkG5A==_1667892165784443000.zip |
+-----------------------------------------------------------+
1 row in set (0.02 sec)

mysql> select * from mysql.plan_replayer_status;
+------------+-------------+-----------------+-----------------------------------------------------------+---------------------+-------------+--------------------+
| sql_digest | plan_digest | origin_sql      | token                                                     | update_time         | fail_reason | instance           |
+------------+-------------+-----------------+-----------------------------------------------------------+---------------------+-------------+--------------------+
| NULL       | NULL        | select * from t | replayer_JsWkHlinw-sAPXLf99zP7w==_1667891378216907000.zip | 2022-11-08 15:09:38 | NULL        | 192.168.51.86:4000 |
| NULL       | NULL        | select * from t | replayer_GSDmlDgMzsB0kH00JpkG5A==_1667892165784443000.zip | 2022-11-08 15:22:45 | NULL        | 192.168.51.86:4000 |
+------------+-------------+-----------------+-----------------------------------------------------------+---------------------+-------------+--------------------+
2 rows in set (0.00 sec)

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Yisaer added 4 commits November 1, 2022 12:48
@Yisaer
refactor
acdd6d7 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
fix lint
74026c4 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
support
77d9af5 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
Merge remote-tracking branch 'upstream/master' into support_replayer_…
c60cfbe 
…capture
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 8, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 8, 2022
Yisaer added 2 commits November 8, 2022 12:24
@Yisaer
revise
9d1bc4a 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
add test
2a3c459 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer Yisaer marked this pull request as ready for review November 8, 2022 07:36
@Yisaer Yisaer requested a review from a team as a code owner November 8, 2022 07:36
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2022
@Yisaer
add test
386f9ab 
Signed-off-by: yisaer <disxiaofei@163.com>
@qw4990 qw4990 added sig/planner SIG: Planner epic/cost-model the optimizer cost model labels Nov 9, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 9, 2022
@Yisaer
fix comment
e0190eb 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer Yisaer force-pushed the support_replayer_capture branch from c3a1c3d to e0190eb Compare November 9, 2022 03:07
@Yisaer Yisaer requested a review from hawkingrei November 9, 2022 08:50
hawkingrei
hawkingrei reviewed Nov 10, 2022
View reviewed changes
@Yisaer
fix liense
e0d1d90 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer Yisaer force-pushed the support_replayer_capture branch from 98b0489 to e0d1d90 Compare November 10, 2022 03:29
@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 10, 2022
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 10, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented Nov 10, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 10, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 8133016

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 10, 2022
@Yisaer Yisaer removed the epic/cost-model the optimizer cost model label Nov 10, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented Nov 10, 2022

/run-check_dev

@ti-chi-bot ti-chi-bot merged commit 066e9c8 into pingcap:master Nov 10, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Nov 10, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [2] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟥 failed 1, success 38, total 39 20 min New failing
idc-jenkins-ci-tidb/sqllogic-test-2 🟥 failed 1, success 27, total 28 5 min 8 sec New failing
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 1, success 5, total 6 43 min Existing failure
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 11 min Existing failure
idc-jenkins-ci-tidb/integration-compatibility-test ✅ all 1 tests passed 2 min 22 sec Fixed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 11 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 3 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 8 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@qw4990 qw4990 qw4990 approved these changes

@Reminiscent Reminiscent Awaiting requested review from Reminiscent

@xuyifangreeneyes xuyifangreeneyes Awaiting requested review from xuyifangreeneyes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support record query replan replayer info if it matches digest.

5 participants

@Yisaer @ti-chi-bot @sre-bot @hawkingrei @qw4990