lightning: support checkpoint read for compress files#38946
lightning: support checkpoint read for compress files#38946ti-chi-bot merged 9 commits intopingcap:masterfrom
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
lance6716
left a comment
There was a problem hiding this comment.
maybe we can update the comment to clarify that pos means the position after decompression.
| } | ||
|
|
||
| // SetRowID sets the rowID in a csv file when we start a compressed file. | ||
| func (parser *CSVParser) SetRowID(rowID int64) { |
There was a problem hiding this comment.
this is not needed because blockParser has implement SetRowID
| ) | ||
| `, "", "") | ||
| require.NoError(t, err) | ||
| core, err := ddl.MockTableInfo(se, node.(*ast.CreateTableStmt), 0xabcdef) |
There was a problem hiding this comment.
we have BuildTableInfoFromAST now
|
@lyzx2001: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: fb59b88 |
TiDB MergeCI notify🔴 Bad News! New failing [2] after this pr merged.
|
What problem does this PR solve?
Issue Number: ref #38514
Problem Summary:
What is changed and how it works?
When lightning reader recovered from breakpoint, use reader to read first few bytes and ignore them.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.