ddl,executor: enhance test for auto_increment with AUTO_ID_CACHE=1#38808
ddl,executor: enhance test for auto_increment with AUTO_ID_CACHE=1#38808ti-chi-bot merged 54 commits intopingcap:masterfrom
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
1727764 to
3b281c3
Compare
executor/insert_test.go
Outdated
| testInsertWithAutoidSchema(t, tk) | ||
| } | ||
|
|
||
| func TestInsertWithAutoidSchemaCache(t *testing.T) { |
There was a problem hiding this comment.
Can we create a executor/auto_id_cache folder to save the test? if the same folder saves too much test to slow the speed of the test when using the bazel.
There was a problem hiding this comment.
Thank you. Please run make bazel_prepare to update the bazel config.
6f49615 to
3685f4f
Compare
| runWithMode("ALLOW_INVALID_DATES") | ||
| } | ||
|
|
||
| func TestInsertWithAutoidSchema(t *testing.T) { |
There was a problem hiding this comment.
| // than that of auto_increment_increment, the value of auto_increment_offset is ignored | ||
| // (https://dev.mysql.com/doc/refman/8.0/en/replication-options-master.html#sysvar_auto_increment_increment), | ||
| // This issue is a flaw of the implementation of MySQL and it doesn't exist in TiDB. | ||
| func TestAutoIDIncrementAndOffset(t *testing.T) { |
There was a problem hiding this comment.
| // 2: ActionRebaseAutoID : it will drop row-id-type allocator. | ||
| // 3: ActionModifyTableAutoIdCache : it will drop row-id-type allocator. | ||
| // 3: ActionRebaseAutoRandomBase : it will drop auto-rand-type allocator. | ||
| func TestFilterDifferentAllocators(t *testing.T) { |
There was a problem hiding this comment.
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
|
/run-unit-test |
|
/run-check_dev_2 |
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: b995f69 |
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
Add test for #38442
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.