Skip to content

*: fix docker script#38602

Merged
ti-chi-bot merged 4 commits intopingcap:masterfrom
xhebox:proxy
Oct 22, 2022
Merged

*: fix docker script#38602
ti-chi-bot merged 4 commits intopingcap:masterfrom
xhebox:proxy

Conversation

@xhebox
Copy link
Contributor

@xhebox xhebox commented Oct 21, 2022

Signed-off-by: xhe xw897002528@gmail.com

What problem does this PR solve?

Issue Number: close None

Problem Summary:

  1. dumb-init is fixed to amd64, and it is also unneeded since tidb now handles SIGTERM util: change graceful shutdown signal #37441. It is removed.
  2. Use alpine:edge which has native dynamic golang support than the official golang static binaries. Should have better compatibilities and possibly higher performance. It is edge because LTS versions of alpine currently does not have go119.
  3. Simpler build scripts and dockerignore.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
make docker
docker run -it tidb:latest
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@xhebox
*: fix docker script
45a963c 
Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 21, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • lcwangchao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 21, 2022
xhebox added 2 commits October 21, 2022 18:03
@xhebox
*: use goproxy
e7f514c 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
*: fix CI
18dadb5 
Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 21, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 22, 2022
@hawkingrei
Copy link
Member

hawkingrei commented Oct 22, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 22, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 18dadb5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 22, 2022
@ti-chi-bot ti-chi-bot merged commit 85b53e1 into pingcap:master Oct 22, 2022
@xhebox xhebox deleted the proxy branch October 22, 2022 03:38
@sre-bot
Copy link
Contributor

sre-bot commented Oct 22, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 30 min Existing passed
idc-jenkins-ci/integration-cdc-test 🟢 all 38 tests passed 22 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 9 min 32 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 12 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 31 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 2 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 41 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 34 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcwangchao lcwangchao lcwangchao approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xhebox @ti-chi-bot @hawkingrei @sre-bot @lcwangchao