Skip to content

executor: fix getting the more result when select * from TIKV_REGION_STATUS where table_id=xx#38601

Merged
ti-chi-bot merged 3 commits intopingcap:masterfrom
Defined2014:fix-37499
Oct 23, 2022
Merged

executor: fix getting the more result when select * from TIKV_REGION_STATUS where table_id=xx#38601
ti-chi-bot merged 3 commits intopingcap:masterfrom
Defined2014:fix-37499

Conversation

@Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Oct 21, 2022

What problem does this PR solve?

Issue Number: close #37499

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    tiup create a cluster, execute sqls below
create table t(a int);
mysql> select * from INFORMATION_SCHEMA.TIKV_REGION_STATUS where table_id in (2,68,70) limit 5;
+-----------+--------------------------------------+--------------------------------------+----------+---------+---------------+----------+----------+------------+----------------+---------------+---------------+------------+------------------+------------------+-------------------------+---------------------------+
| REGION_ID | START_KEY                            | END_KEY                              | TABLE_ID | DB_NAME | TABLE_NAME    | IS_INDEX | INDEX_ID | INDEX_NAME | EPOCH_CONF_VER | EPOCH_VERSION | WRITTEN_BYTES | READ_BYTES | APPROXIMATE_SIZE | APPROXIMATE_KEYS | REPLICATIONSTATUS_STATE | REPLICATIONSTATUS_STATEID |
+-----------+--------------------------------------+--------------------------------------+----------+---------+---------------+----------+----------+------------+----------------+---------------+---------------+------------+------------------+------------------+-------------------------+---------------------------+
|        70 | 7480000000000000FF4400000000000000F8 | 7480000000000000FF4600000000000000F8 |       68 | mysql   | tidb_mdl_view |        0 |     NULL | NULL       |              1 |            35 |            39 |          0 |                1 |                0 | NULL                    |                      NULL |
|         2 | 7480000000000000FF4600000000000000F8 |                                      |       70 | test    | t             |        0 |     NULL | NULL       |              1 |            35 |             0 |    1265250 |                1 |              292 | NULL                    |                      NULL |
+-----------+--------------------------------------+--------------------------------------+----------+---------+---------------+----------+----------+------------+----------------+---------------+---------------+------------+------------------+------------------+-------------------------+---------------------------+
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 21, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 21, 2022
hawkingrei
hawkingrei reviewed Oct 21, 2022
View reviewed changes
hawkingrei
hawkingrei reviewed Oct 21, 2022
View reviewed changes
@hawkingrei hawkingrei self-requested a review October 21, 2022 16:08
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 21, 2022
@Defined2014 Defined2014 requested a review from xhebox October 23, 2022 11:24
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 23, 2022
@xhebox
Copy link
Contributor

xhebox commented Oct 23, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 23, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: a88390a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 23, 2022
@ti-chi-bot ti-chi-bot merged commit 41518c9 into pingcap:master Oct 23, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Oct 23, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 29 min Existing passed
idc-jenkins-ci/integration-cdc-test 🟢 all 38 tests passed 24 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 8 min 35 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 7 min 44 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 43 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 52 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 3 min 53 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 2 min 53 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@Defined2014 Defined2014 deleted the fix-37499 branch November 23, 2022 03:34
@Defined2014 Defined2014 mentioned this pull request Nov 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@xhebox xhebox xhebox approved these changes

@Yisaer Yisaer Awaiting requested review from Yisaer

@zimulala zimulala Awaiting requested review from zimulala

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

When the table is latest created, getting the wrong result select * from TIKV_REGION_STATUS where table_id=xx;

5 participants

@Defined2014 @ti-chi-bot @xhebox @sre-bot @hawkingrei