Skip to content

extension: allow extension to custom functions#38567

Merged
ti-chi-bot merged 11 commits intopingcap:masterfrom
lcwangchao:extension_func
Oct 24, 2022
Merged

extension: allow extension to custom functions#38567
ti-chi-bot merged 11 commits intopingcap:masterfrom
lcwangchao:extension_func

Conversation

@lcwangchao
Copy link
Collaborator

@lcwangchao lcwangchao commented Oct 20, 2022

What problem does this PR solve?

Issue Number: close #38566

Problem Summary:

What is changed and how it works?

allow extension to custom functions, see the test cases in detail

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 20, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 20, 2022
hawkingrei
hawkingrei reviewed Oct 20, 2022
View reviewed changes
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 20, 2022
bb7133
bb7133 reviewed Oct 21, 2022
View reviewed changes
bb7133
bb7133 approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 21, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 24, 2022
@xhebox
Copy link
Contributor

xhebox commented Oct 24, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 24, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 6f09820

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 24, 2022
@lcwangchao
Copy link
Collaborator Author

lcwangchao commented Oct 24, 2022

/rebuild

@lcwangchao
Copy link
Collaborator Author

lcwangchao commented Oct 24, 2022

/run-unit-test

@lcwangchao
Copy link
Collaborator Author

lcwangchao commented Oct 24, 2022

/run-all-tests

@lcwangchao
Copy link
Collaborator Author

lcwangchao commented Oct 24, 2022

/run-check_dev_2

@lcwangchao
Copy link
Collaborator Author

lcwangchao commented Oct 24, 2022

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit ad0f7d2 into pingcap:master Oct 24, 2022
@lcwangchao lcwangchao deleted the extension_func branch October 24, 2022 03:51
@sre-bot
Copy link
Contributor

sre-bot commented Oct 24, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 29 min Existing passed
idc-jenkins-ci/integration-cdc-test 🟢 all 38 tests passed 24 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 16 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 9 min 28 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 18 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 39 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 59 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 58 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkingrei hawkingrei hawkingrei left review comments

@bb7133 bb7133 bb7133 approved these changes

@xhebox xhebox xhebox approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow extension to custom functions

6 participants

@lcwangchao @ti-chi-bot @xhebox @sre-bot @bb7133 @hawkingrei