Skip to content

bazel: update config and nogo#38549

Merged
ti-chi-bot merged 2 commits intopingcap:masterfrom
hawkingrei:update_bazel_20221019
Oct 19, 2022
Merged

bazel: update config and nogo#38549
ti-chi-bot merged 2 commits intopingcap:masterfrom
hawkingrei:update_bazel_20221019

Conversation

@hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Oct 19, 2022 •
edited
Loading

Signed-off-by: Weizhen Wang wangweizhen@pingcap.com

What problem does this PR solve?

Issue Number: close None

Problem Summary:

What is changed and how it works?

update bazel config and fix the wrong comment in the nogo config.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    run in CI
  • No code

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@hawkingrei
bazel: update config and nogo
a0bfd96 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 19, 2022
@hawkingrei hawkingrei requested a review from bb7133 October 19, 2022 08:17
@hawkingrei
bazel: update config and nogo
812354d 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 19, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 19, 2022
@Defined2014
Copy link
Contributor

Defined2014 commented Oct 19, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 19, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 812354d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 19, 2022
@ti-chi-bot ti-chi-bot merged commit 51e559c into pingcap:master Oct 19, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Oct 19, 2022

TiDB MergeCI notify

🔴 Bad News! [2] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 37, total 38 22 min Existing failure
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 1, success 16, total 17 13 min Existing failure
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 30 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 9 min 25 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 47 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 55 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 35 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 2 min 55 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 44 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhebox xhebox xhebox approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

@YangKeao YangKeao Awaiting requested review from YangKeao

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hawkingrei @ti-chi-bot @Defined2014 @sre-bot @xhebox