Skip to content

statistics, planner: make the content in HistColl.ColID2IdxIDs stable#38458

Merged
ti-chi-bot merged 11 commits intopingcap:masterfrom
time-and-fate:issue38457
Oct 18, 2022
Merged

statistics, planner: make the content in HistColl.ColID2IdxIDs stable#38458
ti-chi-bot merged 11 commits intopingcap:masterfrom
time-and-fate:issue38457

Conversation

@time-and-fate
Copy link
Member

@time-and-fate time-and-fate commented Oct 13, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #38457

What is changed and how it works?

  1. Make HistColl.ColID2IdxID contains all possible indexes in a stable order.
  2. Prefer column stats over index stats in expBackoffEstimation
  3. Do not recursively call GetRowCountByIndexRanges in expBackoffEstimation if we are handling a single-column range. This change avoids infinite recursion after changes in 1.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 13, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • winoros
  • xuyifangreeneyes

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 13, 2022
@time-and-fate
Copy link
Member Author

time-and-fate commented Oct 13, 2022

/run-build

@time-and-fate time-and-fate reopened this Oct 14, 2022
@time-and-fate
Copy link
Member Author

time-and-fate commented Oct 14, 2022

/run-build
/run-unit-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 18, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 18, 2022
@time-and-fate
Copy link
Member Author

time-and-fate commented Oct 18, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 18, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 63c398a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 18, 2022
@time-and-fate
Copy link
Member Author

time-and-fate commented Oct 18, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 22b85b9 into pingcap:master Oct 18, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Oct 18, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 1, success 5, total 6 23 min New failing
idc-jenkins-ci-tidb/integration-common-test 🔴 2 min 3 sec Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 38 tests passed 32 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 15 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 9 min 4 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 55 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 44 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 16 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 56 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@time-and-fate time-and-fate mentioned this pull request Oct 28, 2022
Closed
12 tasks
@time-and-fate time-and-fate mentioned this pull request Oct 28, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@winoros winoros winoros approved these changes

+1 more reviewer

@xuyifangreeneyes xuyifangreeneyes xuyifangreeneyes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make the content in HistColl.ColID2IdxIDs stable

5 participants

@time-and-fate @ti-chi-bot @sre-bot @winoros @xuyifangreeneyes