Skip to content

dumpling: add recent speed to dump status#38456

Merged
ti-chi-bot merged 9 commits intopingcap:masterfrom
okJiang:dumpling-add-speed
Oct 17, 2022
Merged

dumpling: add recent speed to dump status#38456
ti-chi-bot merged 9 commits intopingcap:masterfrom
okJiang:dumpling-add-speed

Conversation

@okJiang
Copy link
Member

@okJiang okJiang commented Oct 13, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #38455

Problem Summary:

  • add recent speed to dump status

similar pr: pingcap/tiflow#7212, tiflow will import tidb's SpeedRecorder after this pr merged.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 13, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 13, 2022
lance6716
lance6716 reviewed Oct 13, 2022
View reviewed changes
@okJiang okJiang changed the title [DNM] dumpling: add recent speed to dump status dumpling: add recent speed to dump status Oct 13, 2022
@okJiang okJiang marked this pull request as ready for review October 13, 2022 13:57
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2022
@okJiang okJiang mentioned this pull request Oct 14, 2022
Closed
D3Hunter
D3Hunter reviewed Oct 14, 2022
View reviewed changes
okJiang and others added 3 commits October 14, 2022 10:55
@okJiang
Copy link
Member Author

okJiang commented Oct 14, 2022

/run-all-tests

lance6716
lance6716 approved these changes Oct 17, 2022
View reviewed changes
dumpling/export/dump.go Outdated
totalTables int64
charsetAndDefaultCollationMap map[string]string

statusRecorder *StatusRecorder
Copy link
Contributor

@lance6716 lance6716 Oct 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry now I want to change the name to SpeedRecorder or something

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 17, 2022
GMHDBJD
GMHDBJD reviewed Oct 17, 2022
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

dumpling/export/status.go
elapsed = 1
}
currentSpeed := (finished - s.lastFinished) / elapsed
if currentSpeed == 0 {
Copy link
Contributor

@GMHDBJD GMHDBJD Oct 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use float variable?

Copy link
Member Author

@okJiang okJiang Oct 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the unit of measurement should be Byte/s, so no need to use float.

GMHDBJD
GMHDBJD approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 17, 2022
@GMHDBJD
Copy link
Contributor

GMHDBJD commented Oct 17, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 17, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: b047955

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 17, 2022
@ti-chi-bot ti-chi-bot merged commit aa49a4c into pingcap:master Oct 17, 2022
@okJiang okJiang deleted the dumpling-add-speed branch October 17, 2022 09:11
@sre-bot
Copy link
Contributor

sre-bot commented Oct 17, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 1, success 5, total 6 29 min New failing
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 2, success 15, total 17 20 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 29 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 16 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 9 min 24 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 9 min 5 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 32 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 2 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 32 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@D3Hunter D3Hunter D3Hunter left review comments

@lance6716 lance6716 lance6716 approved these changes

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dumpling status need a speed

6 participants

@okJiang @ti-chi-bot @GMHDBJD @sre-bot @lance6716 @D3Hunter