Skip to content

ddl: LINEAR HASH as HASH partitioned table#38451

Merged
ti-chi-bot merged 4 commits intopingcap:masterfrom
mjonss:linear-hash-as-hash
Oct 19, 2022
Merged

ddl: LINEAR HASH as HASH partitioned table#38451
ti-chi-bot merged 4 commits intopingcap:masterfrom
mjonss:linear-hash-as-hash

Conversation

@mjonss
Copy link
Contributor

@mjonss mjonss commented Oct 13, 2022

What problem does this PR solve?

Issue Number: close #38450

Problem Summary:

Currently a CREATE TABLE ... PARTITION BY LINEAR HASH ... ignores the full PARTITION BY clause and creates a non-partitioned table, with a warning.
This PR changes it to only ignore the LINEAR keyword and creates a HASH partitioned table, with a warning.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

For CREATE TABLE ... PARTITION BY LINEAR HASH ... create a non-linear HASH partitioned table instead of a non-partitioned table.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 13, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 13, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 17, 2022
bb7133
bb7133 approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 19, 2022
@bb7133
Copy link
Member

bb7133 commented Oct 19, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 19, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 1a45d58

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 19, 2022
@ti-chi-bot ti-chi-bot merged commit 298ce91 into pingcap:master Oct 19, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Oct 19, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 1, success 5, total 6 4 min 13 sec New failing
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 37, total 38 23 min Existing failure
idc-jenkins-ci-tidb/integration-common-test ✅ all 17 tests passed 13 min Fixed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 8 min 52 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 23 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 33 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 23 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 4 min 4 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 2 min 54 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@YangKeao YangKeao mentioned this pull request Jun 30, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 bb7133 approved these changes

@xhebox xhebox xhebox approved these changes

Assignees

No one assigned

Labels

release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make LINEAR HASH use a HASH partitioned table, instead of a non-partitioned table

5 participants

@mjonss @ti-chi-bot @bb7133 @sre-bot @xhebox