*: add context for preprocess#38360
Merged
ti-chi-bot merged 4 commits intopingcap:masterfrom Oct 18, 2022
Merged
Conversation
Member
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
Member
Author
|
/run-all-tests |
Member
Author
|
/run-mysql-test |
xhebox
approved these changes
Oct 11, 2022
3e88410 to
b64313e
Compare
Member
Author
|
/tests |
lcwangchao
reviewed
Oct 17, 2022
c42ae6d to
7d0bfa3
Compare
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
7d0bfa3 to
9607fff
Compare
hawkingrei
approved these changes
Oct 17, 2022
Member
Author
|
@hawkingrei @xhebox Could you help me to merge this PR? |
Contributor
|
/merge |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 9607fff |
Contributor
TiDB MergeCI notify🔴 Bad News! [1] CI still failing after this pr merged.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YangKeao yangkeao@chunibyo.icu
What problem does this PR solve?
Issue Number: close #38359
Problem Summary:
The
Preprocessfunction doesn't receive and pass in thectx context.Contextarguments. As described in #38359, it's needed by the external-timestamp read feature.What is changed and how it works?
Add
ctx context.Contextarguments for every related functions. And I don't change the ast visitor interface (because it will cause too many changes), but add a field ctx in in the preprocessor struct.