Skip to content

*: remove non dry sysvar code#38182

Merged
ti-chi-bot merged 4 commits intopingcap:masterfrom
morgo:remove-non-dry-sysvar-code
Oct 9, 2022
Merged

*: remove non dry sysvar code#38182
ti-chi-bot merged 4 commits intopingcap:masterfrom
morgo:remove-non-dry-sysvar-code

Conversation

@morgo
Copy link
Contributor

@morgo morgo commented Sep 26, 2022

What problem does this PR solve?

Issue Number: close #33896

Problem Summary:

When setting a special sysvar that requires the domain, there is duplicate code in executor/set.go and domain/sysvar_cache.go. This is because a SetGlobal func can not be directly used, because the domain is not available.

It is possible to workaround this by creating a noop func in variable which is overwritten when the NewDomain is created. This helps simplify the code because by being non-DRY it has a high chance of introducing future bugs if only one location is updated correctly. Because the sysvar cache code runs async, it is also unlikely that these bugs will easily be caught.

What is changed and how it works?

Function neutral change.

Check List

Tests

  • Unit test
    Covered by existing tests.
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@morgo morgo requested a review from a team as a code owner September 26, 2022 18:05
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 26, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CbcWestwolf
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 26, 2022
@morgo morgo requested a review from bb7133 September 26, 2022 18:32
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 27, 2022
@morgo morgo mentioned this pull request Oct 4, 2022
Merged
4 tasks
YangKeao
YangKeao approved these changes Oct 8, 2022
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 8, 2022

@YangKeao: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@YangKeao
Copy link
Member

YangKeao commented Oct 8, 2022

Good job! I'll revert #38227 after this PR merged 🍻

@YangKeao YangKeao mentioned this pull request Oct 8, 2022
Merged
20 tasks
@YangKeao YangKeao requested a review from xhebox October 8, 2022 11:04
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 9, 2022
@YangKeao
Copy link
Member

YangKeao commented Oct 9, 2022

@xhebox Could you help to merge this PR?

@xhebox
Copy link
Contributor

xhebox commented Oct 9, 2022

@xhebox Could you help to merge this PR?

This PR needs configuration OWNER to approve and merge, /cc @bb7133

bb7133
bb7133 approved these changes Oct 9, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member

bb7133 commented Oct 9, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 9, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 0727a82

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 9, 2022
@morgo
Copy link
Contributor Author

morgo commented Oct 9, 2022

/run-build

@ti-chi-bot ti-chi-bot merged commit b0e0cc2 into pingcap:master Oct 9, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Oct 9, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 1, success 5, total 6 4 min 24 sec New failing
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 8 min 45 sec Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 26 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 11 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 24 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 35 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 3 min 55 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 14 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 45 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 bb7133 approved these changes

@YangKeao YangKeao YangKeao approved these changes

@xhebox xhebox xhebox approved these changes

@CbcWestwolf CbcWestwolf CbcWestwolf approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

simplify SET GLOBAL code

7 participants

@morgo @ti-chi-bot @YangKeao @xhebox @bb7133 @sre-bot @CbcWestwolf