Skip to content

planner: PhysicalPlan memory trace 8#38162

Merged
ti-chi-bot merged 12 commits intopingcap:masterfrom
fzzf678:physicalPlan_memTrace_8
Sep 27, 2022
Merged

planner: PhysicalPlan memory trace 8#38162
ti-chi-bot merged 12 commits intopingcap:masterfrom
fzzf678:physicalPlan_memTrace_8

Conversation

@fzzf678
Copy link
Contributor

@fzzf678 fzzf678 commented Sep 26, 2022

What problem does this PR solve?

Issue Number: ref #37632

Problem Summary:

What is changed and how it works?

Implement MemoryUsage function for

  • PhysicalSimpleWrapper
  • PhysicalMemTable
  • PhysicalExchangeReceiver
  • PhysicalExchangeSender
  • PhysicalLock

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 26, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 26, 2022
@fzzf678 fzzf678 mentioned this pull request Sep 26, 2022
Closed
25 tasks
@fzzf678 fzzf678 marked this pull request as ready for review September 27, 2022 06:24
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 27, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 27, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 27, 2022
@hawkingrei
Copy link
Member

hawkingrei commented Sep 27, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 27, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 7aae51e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 27, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 27, 2022

@fzzf678: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit c5a28bf into pingcap:master Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qw4990 qw4990 qw4990 approved these changes

+1 more reviewer

@Reminiscent Reminiscent Reminiscent approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fzzf678 @ti-chi-bot @hawkingrei @qw4990 @Reminiscent