store/copr: update copr-cache admission for paging and initial copr task's paging size (#38012)#38077
store/copr: update copr-cache admission for paging and initial copr task's paging size (#38012)#38077ti-srebot wants to merge 1 commit intopingcap:release-6.3from
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
|
/run-all-tests |
|
@tiancaiamao you're already a collaborator in bot's repo. |
|
@ti-srebot: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
not maintained version |
cherry-pick #38012 to release-6.3
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/38077After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #37768 #37974
Problem Summary:
What is changed and how it works?
I figure out that for Q17, the root cause of the issue is copr-cache #37768 (comment)
When paging is disabled, the copr cache admission check would check the copr request data size < 10M
When paging is enable, this check become useless because the data is much smaller.
I add a
pagingTaskIdxand check ifpagingTaskIdxis large, don't cache the data.Check List
Tests
I'll run the TPCH bench bot to verify the change work.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.