Skip to content

store/copr: update copr-cache admission for paging and initial copr task's paging size (#38012)#38077

Closed
ti-srebot wants to merge 1 commit intopingcap:release-6.3from
ti-srebot:release-6.3-16693f8cd2f6
Closed

store/copr: update copr-cache admission for paging and initial copr task's paging size (#38012)#38077
ti-srebot wants to merge 1 commit intopingcap:release-6.3from
ti-srebot:release-6.3-16693f8cd2f6

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Sep 22, 2022

cherry-pick #38012 to release-6.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/38077

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/38077:release-6.3-16693f8cd2f6

What problem does this PR solve?

Issue Number: close #37768 #37974

Problem Summary:

What is changed and how it works?

I figure out that for Q17, the root cause of the issue is copr-cache #37768 (comment)

When paging is disabled, the copr cache admission check would check the copr request data size < 10M
When paging is enable, this check become useless because the data is much smaller.

I add a pagingTaskIdx and check if pagingTaskIdx is large, don't cache the data.

Check List

Tests

  • Unit test
  • Integration test

I'll run the TPCH bench bot to verify the change work.

  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 22, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 22, 2022
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/6.3-cherry-pick labels Sep 22, 2022
@ti-srebot
Copy link
Contributor Author

@tiancaiamao you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 22, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 22, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 28, 2022
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels Nov 4, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 29, 2022

@ti-srebot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/mysql-test 28e8315 link true /test mysql-test
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xhebox
Copy link
Contributor

xhebox commented Dec 29, 2022

not maintained version

@xhebox xhebox closed this Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/6.3-cherry-pick

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants