planner: PhysicalPlan memory trace 7#38030
Merged
ti-chi-bot merged 12 commits intopingcap:masterfrom Sep 23, 2022
Merged
Conversation
Member
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
25 tasks
qw4990
reviewed
Sep 22, 2022
planner/core/logical_plans.go
Outdated
| return | ||
| } | ||
|
|
||
| sum = emptyCTEClassSize + cc.seedPartPhysicalPlan.MemoryUsage() + cc.recursivePartPhysicalPlan.MemoryUsage() |
Contributor
There was a problem hiding this comment.
Is that safe to call MemoyUsage even if seedPartPhysicalPlan is nil?
qw4990
approved these changes
Sep 22, 2022
Reminiscent
approved these changes
Sep 23, 2022
Contributor
|
/merge |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 7826848 |
Contributor
TiDB MergeCI notify✅ Well Done! New fixed [2] after this pr merged.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #37632
Problem Summary:
What is changed and how it works?
Implement MemoryUsage() for
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.