Skip to content

helper: request another PD if one of them is unavailable (#35750)#37781

Merged
ti-chi-bot merged 1 commit intopingcap:release-6.1from
ti-srebot:release-6.1-8097685436fd
Sep 14, 2022
Merged

helper: request another PD if one of them is unavailable (#35750)#37781
ti-chi-bot merged 1 commit intopingcap:release-6.1from
ti-srebot:release-6.1-8097685436fd

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Sep 13, 2022 •
edited
Loading

cherry-pick #35750 to release-6.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/37781

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/37781:release-6.1-8097685436fd

What problem does this PR solve?

Issue Number: close #35708.

Problem Summary:

requestPD should try the PD hosts one by one until the request is successful.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix an issue that TiDB cannot access `TIKV_REGION_STATUS` when one of the PD is down.

@ti-srebot
cherry pick pingcap#35750 to release-6.1
3c21a6a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 13, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

ti-srebot commented Sep 13, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 13, 2022
@ti-srebot ti-srebot mentioned this pull request Sep 13, 2022
Merged
12 tasks
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/6.1-cherry-pick labels Sep 13, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 13, 2022
@ti-srebot ti-srebot added this to the v6.1.1 milestone Sep 13, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 13, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 13, 2022
@nolouch
Copy link
Member

nolouch commented Sep 13, 2022 •
edited
Loading

PTAL @JmPotato @tangenta

@nolouch
Copy link
Member

nolouch commented Sep 13, 2022 •
edited
Loading

ref #35708, #37764

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 14, 2022
AndreMouche
AndreMouche approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndreMouche
Copy link
Contributor

AndreMouche commented Sep 14, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 14, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 3c21a6a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 14, 2022
@ti-chi-bot ti-chi-bot merged commit 3ba4538 into pingcap:release-6.1 Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndreMouche AndreMouche AndreMouche approved these changes

@JmPotato JmPotato JmPotato approved these changes

@nolouch nolouch nolouch approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees

No one assigned

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/6.1-cherry-pick

Projects

None yet

Milestone

v6.1.1

Development

Successfully merging this pull request may close these issues.

7 participants

@ti-srebot @ti-chi-bot @nolouch @AndreMouche @JmPotato @VelocityLight @tangenta