Skip to content

infoschema: fix PromQL for tidb_distsql_copr_cache (#36450)#36484

Merged
ti-chi-bot merged 2 commits intopingcap:release-6.2from
ti-srebot:release-6.2-435dc5849f5d
Jul 25, 2022
Merged

infoschema: fix PromQL for tidb_distsql_copr_cache (#36450)#36484
ti-chi-bot merged 2 commits intopingcap:release-6.2from
ti-srebot:release-6.2-435dc5849f5d

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jul 22, 2022 •
edited
Loading

cherry-pick #36450 to release-6.2
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/36484

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/36484:release-6.2-435dc5849f5d

What problem does this PR solve?

Issue Number: close #35856

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

use tiup playground to create a cluster, then execute select count(1) from information_schema.metrics_summary

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix metric sql error

@Defined2014 @ti-srebot
cherry pick pingcap#36450 to release-6.2
890dfb6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 22, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

ti-srebot commented Jul 22, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 22, 2022
@ti-srebot ti-srebot mentioned this pull request Jul 22, 2022
Merged
12 tasks
@ti-srebot ti-srebot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/6.2-cherry-pick labels Jul 22, 2022
@ti-srebot ti-srebot requested review from hawkingrei, ngaut and xhebox July 22, 2022 11:10
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Jul 22, 2022

@Defined2014 you're already a collaborator in bot's repo.

@sre-bot
Copy link
Contributor

sre-bot commented Jul 22, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/99920e5570932595abde9e2eecd0dc0f44576136

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 22, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 22, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 25, 2022
@Defined2014
Copy link
Contributor

Defined2014 commented Jul 25, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 25, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 890dfb6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 25, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 25, 2022

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit dc8403b into pingcap:release-6.2 Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhebox xhebox xhebox approved these changes

@tangenta tangenta tangenta approved these changes

@hawkingrei hawkingrei Awaiting requested review from hawkingrei

@ngaut ngaut Awaiting requested review from ngaut

Assignees

@Defined2014 Defined2014

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/6.2-cherry-pick

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ti-srebot @ti-chi-bot @sre-bot @Defined2014 @xhebox @tangenta @VelocityLight