Skip to content

executor: fix aggregating enum zero value gets different results from mysql (#36208)#36463

Closed
ti-srebot wants to merge 2 commits intopingcap:release-5.4from
ti-srebot:release-5.4-065563a8ea4e
Closed

executor: fix aggregating enum zero value gets different results from mysql (#36208)#36463
ti-srebot wants to merge 2 commits intopingcap:release-5.4from
ti-srebot:release-5.4-065563a8ea4e

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jul 22, 2022 •
edited
Loading

cherry-pick #36208 to release-5.4
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/36463

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/36463:release-5.4-065563a8ea4e

What problem does this PR solve?

Issue Number: close #26885

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ywqzzy @ti-srebot
cherry pick pingcap#36208 to release-5.4
9094005 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 22, 2022

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 22, 2022

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Contributor Author

ti-srebot commented Jul 22, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. labels Jul 22, 2022
@ti-srebot ti-srebot mentioned this pull request Jul 22, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jul 22, 2022
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.4-cherry-pick labels Jul 22, 2022
@ti-srebot ti-srebot added this to the v5.4.1 milestone Jul 22, 2022
@ti-chi-bot ti-chi-bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 22, 2022
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Jul 22, 2022

@ywqzzy you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 22, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 22, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 22, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/3867d0eba46c0244e853087b99b74ad2c32a30dd

@ywqzzy
Copy link
Contributor

ywqzzy commented Jul 22, 2022

/close

@ti-chi-bot ti-chi-bot closed this Jul 22, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 22, 2022

@ywqzzy: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mengxin9014 mengxin9014 Awaiting requested review from mengxin9014

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees

@ywqzzy ywqzzy

Labels

do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.4-cherry-pick

Projects

None yet

Milestone

v5.4.1

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-srebot @ti-chi-bot @sre-bot @ywqzzy