Skip to content

ddl: invalid multiple MAXVALUE partitions (#36329) (#36345)#36442

Merged
ti-chi-bot merged 2 commits intopingcap:release-5.1from
ti-srebot:release-5.1-121a6669a85c
Aug 3, 2022
Merged

ddl: invalid multiple MAXVALUE partitions (#36329) (#36345)#36442
ti-chi-bot merged 2 commits intopingcap:release-5.1from
ti-srebot:release-5.1-121a6669a85c

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jul 21, 2022 •
edited
Loading

cherry-pick #36345 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/36442

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/36442:release-5.1-121a6669a85c

Signed-off-by: u5surf u5.horie@gmail.com

What problem does this PR solve?

Issue Number: close #36329

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release-note

None

@u5surf @ti-srebot
cherry pick pingcap#36345 to release-5.1
5e8cbad 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 21, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

ti-srebot commented Jul 21, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. labels Jul 21, 2022
@ti-srebot ti-srebot mentioned this pull request Jul 21, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jul 21, 2022
@ti-srebot ti-srebot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.1-cherry-pick labels Jul 21, 2022
@ti-srebot ti-srebot requested review from Defined2014 and mjonss July 21, 2022 17:00
@ti-srebot ti-srebot added this to the v5.1.4 milestone Jul 21, 2022
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Jul 21, 2022

@Defined2014 you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 22, 2022
@xhebox
*: fix CI
8acbc7d 
Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 27, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 27, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/8acbc7dbc7a7d72b05f0874f164ca18f807dbade

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 3, 2022
@Defined2014
Copy link
Contributor

Defined2014 commented Aug 3, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 3, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 8acbc7d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2022
@ti-chi-bot ti-chi-bot merged commit c371af6 into pingcap:release-5.1 Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhebox xhebox xhebox approved these changes

@mjonss mjonss mjonss approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

Assignees

@Defined2014 Defined2014

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.1-cherry-pick

Projects

None yet

Milestone

v5.1.4

Development

Successfully merging this pull request may close these issues.

8 participants

@ti-srebot @ti-chi-bot @sre-bot @Defined2014 @xhebox @mjonss @VelocityLight @u5surf