expression: support get_format pushdown to tiflash by wirybeaver · Pull Request #35950 · pingcap/tidb

wirybeaver · 2022-07-05T06:45:40Z

What problem does this PR solve?

Issue Number: close #36035

Problem Summary:
Support get_format pushdown to TiFlash on TiDB side. Related TiFlash Issue: pingcap/tiflash#5115

What is changed and how it works?

function scalarExprSupportedByFlash return true when encountering the AST GetFormat node.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

support get_format pushdown to TiFlash.

ti-chi-bot · 2022-07-05T06:45:42Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

wshwsh12
zanmato1984

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

sre-bot · 2022-07-05T06:45:46Z

All committers have signed the CLA.

ti-chi-bot · 2022-07-05T06:45:52Z

Welcome @wirybeaver!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to pingcap/tidb. 😃

sre-bot · 2022-07-05T06:46:11Z

Please follow PR Title Format:

pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

*: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

sre-bot · 2022-07-05T07:04:56Z

Please follow PR Title Format:

pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

*: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

wirybeaver · 2022-07-05T07:05:41Z

/run-all-test

wirybeaver · 2022-07-05T07:08:12Z

/run-all-tests

sre-bot · 2022-07-05T07:08:51Z

Please follow PR Title Format:

pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

*: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

sre-bot · 2022-07-05T07:14:32Z

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/ad0e1ef04e6d8664090e8ec67cb4cbb3c36a4d8b

zanmato1984 · 2022-07-06T10:42:37Z

Please add some UT. You can see this PR #35739 as a reference.

wirybeaver · 2022-07-08T05:13:31Z

/run-check_title

…i/getFormat Merge reason: fall behind.

wirybeaver · 2022-07-08T19:53:17Z

[2022-07-08T19:01:26.601Z]   /home/jenkins/.tidb/tmp/b7c8fa3cc70b7c7023fdc4f79d50df0e/execroot/__main__/bazel-out/k8-fastbuild/testlogs/tests/realtikvtest/sessiontest/sessiontest_test/shard_4_of_50/coverage.dat
[2022-07-08T19:01:26.601Z] //statistics/handle:handle_test                                           FLAKY, failed in 1 out of 51 in 9.4s

Flaky unit test caused by TiKV.

wirybeaver · 2022-07-12T05:36:58Z

Release note only need to write as support get_format pushdown to TiFlash.

Done

expression/expression.go

…Format

zanmato1984

LGTM

zanmato1984 · 2022-07-14T02:28:47Z

/merge

ti-chi-bot · 2022-07-14T02:28:49Z

@zanmato1984: /merge in this pull request requires 2 approval(s).

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-07-14T02:30:03Z

@SeaRise: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-07-14T02:36:18Z

@mengxin9014: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

zanmato1984 · 2022-07-14T02:53:40Z

/merge

ti-chi-bot · 2022-07-14T02:53:43Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: 2146c8d

zanmato1984 · 2022-07-14T03:02:48Z

/run-unit-test

zanmato1984 · 2022-07-14T03:35:07Z

/run-mysql-test

sre-bot · 2022-07-14T04:31:21Z

TiDB MergeCI notify

🔴 Bad News! [1] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name	Result	Duration	Compare with Parent commit
idc-jenkins-ci/integration-cdc-test	🔴 failed 1, success 35, total 36	30 min	Existing failure
idc-jenkins-ci-tidb/integration-common-test	🟢 all 11 tests passed	28 min	Existing passed
idc-jenkins-ci-tidb/common-test	🟢 all 12 tests passed	13 min	Existing passed
idc-jenkins-ci-tidb/tics-test	🟢 all 1 tests passed	8 min 8 sec	Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2	🟢 all 28 tests passed	7 min 9 sec	Existing passed
idc-jenkins-ci-tidb/integration-ddl-test	🟢 all 6 tests passed	7 min 2 sec	Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1	🟢 all 26 tests passed	5 min 47 sec	Existing passed
idc-jenkins-ci-tidb/mybatis-test	🟢 all 1 tests passed	5 min 13 sec	Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test	🟢 all 1 tests passed	5 min 13 sec	Existing passed
idc-jenkins-ci-tidb/plugin-test	🟢 build success, plugin test success	4min	Existing passed

support get_format pushdown to tiflash

39cbca7

ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 5, 2022

ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 5, 2022

wirybeaver mentioned this pull request Jul 5, 2022

feat: pushdown get_format into TiFlash pingcap/tiflash#5269

Merged

12 tasks

Merge branch 'master' into xuanyili/getFormat

16d57bd

wirybeaver marked this pull request as draft July 7, 2022 00:01

ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2022

wirybeaver changed the title ~~support get_format pushdown to tiflash~~ [WIP] support get_format pushdown to tiflash Jul 7, 2022

wirybeaver changed the title ~~[WIP] support get_format pushdown to tiflash~~ expression: support get_format pushdown to tiflash Jul 8, 2022

ti-chi-bot removed the do-not-merge/needs-linked-issue label Jul 8, 2022

wirybeaver added 3 commits July 7, 2022 23:10

add unit test; integeration test is on the way

50460c4

Merge remote-tracking branch 'origin/xuanyili/getFormat' into xuanyil…

19dba5e

…i/getFormat Merge reason: fall behind.

add integration test

5c29005

ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 8, 2022

Merge branch 'master' into xuanyili/getFormat

d9990d4

wirybeaver marked this pull request as ready for review July 8, 2022 19:57

zanmato1984 reviewed Jul 12, 2022

View reviewed changes

expression/expression.go Outdated Show resolved Hide resolved

return true directly for getformat pushdown check own to non overloading

d7c3951

ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 13, 2022

Merge remote-tracking branch 'upstream-fork/master' into xuanyili/get…

2146c8d

…Format

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2022

wirybeaver requested a review from zanmato1984 July 13, 2022 16:01

zanmato1984 approved these changes Jul 14, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 14, 2022

SeaRise approved these changes Jul 14, 2022

View reviewed changes

mengxin9014 approved these changes Jul 14, 2022

View reviewed changes

wshwsh12 approved these changes Jul 14, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 14, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 14, 2022

Merge branch 'master' into xuanyili/getFormat

765d99e

Merge branch 'master' into xuanyili/getFormat

ad0e1ef

ti-chi-bot merged commit 74102dd into pingcap:master Jul 14, 2022

Conversation

wirybeaver commented Jul 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

Uh oh!

ti-chi-bot commented Jul 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sre-bot commented Jul 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ti-chi-bot commented Jul 5, 2022

Uh oh!

sre-bot commented Jul 5, 2022

Uh oh!

sre-bot commented Jul 5, 2022

Uh oh!

wirybeaver commented Jul 5, 2022

Uh oh!

wirybeaver commented Jul 5, 2022

Uh oh!

sre-bot commented Jul 5, 2022

Uh oh!

sre-bot commented Jul 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zanmato1984 commented Jul 6, 2022

Uh oh!

wirybeaver commented Jul 8, 2022

Uh oh!

wirybeaver commented Jul 8, 2022

Uh oh!

wirybeaver commented Jul 12, 2022

Uh oh!

Uh oh!

zanmato1984 left a comment

Choose a reason for hiding this comment

Uh oh!

zanmato1984 commented Jul 14, 2022

Uh oh!

ti-chi-bot commented Jul 14, 2022

Uh oh!

ti-chi-bot commented Jul 14, 2022

Uh oh!

ti-chi-bot commented Jul 14, 2022

Uh oh!

zanmato1984 commented Jul 14, 2022

Uh oh!

ti-chi-bot commented Jul 14, 2022

Uh oh!

zanmato1984 commented Jul 14, 2022

Uh oh!

zanmato1984 commented Jul 14, 2022

Uh oh!

sre-bot commented Jul 14, 2022

TiDB MergeCI notify

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

wirybeaver commented Jul 5, 2022 •

edited

Loading

ti-chi-bot commented Jul 5, 2022 •

edited

Loading

sre-bot commented Jul 5, 2022 •

edited

Loading

sre-bot commented Jul 5, 2022 •

edited

Loading