Skip to content

feat: push down hexInt/hexStr function to tiflash#35902

Merged
ti-chi-bot merged 11 commits intopingcap:masterfrom
YangKeao:impl-hex-int-str-arg-tiflash
Aug 5, 2022
Merged

feat: push down hexInt/hexStr function to tiflash#35902
ti-chi-bot merged 11 commits intopingcap:masterfrom
YangKeao:impl-hex-int-str-arg-tiflash

Conversation

@YangKeao
Copy link
Member

@YangKeao YangKeao commented Jul 3, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #35901

Related PR: pingcap/tiflash#5280

Problem Summary:

Implement hexInt/hexStr function push down.

What is changed and how it works?

TiDB Side: add ast.Hex to the scalarExprSupportedByFlash function to push down.

TiFlash Side:

  • hexStr is manually implemented through convert every bytes to two characters.
  • hexInt is implemented by calling sprintf(_, "%X", _) directly.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Support to pushdown hexInt/hexStr to TiFlash

YangKeao added 2 commits July 3, 2022 20:55
@YangKeao
implement hex str pushdown
07cb9f3 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao
implement hexInt pushdown
3dd85f1 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 3, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SeaRise
  • guo-shaoge

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 3, 2022
@YangKeao YangKeao mentioned this pull request Jul 3, 2022
Merged
2 tasks
@SeaRise
Copy link
Contributor

SeaRise commented Jul 11, 2022

Please add some UT. You can see this PR #35739 as a reference.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2022
@SeaRise
Copy link
Contributor

SeaRise commented Jul 21, 2022

/cc @SeaRise

@ti-chi-bot ti-chi-bot requested a review from SeaRise July 21, 2022 20:57
@SeaRise
Copy link
Contributor

SeaRise commented Aug 4, 2022

@YangKeao
friendly ping~ any updated?

YangKeao added 3 commits August 4, 2022 16:27
@YangKeao
Merge remote-tracking branch 'upstream/master' into impl-hex-int-str-…
c1cc4be 
…arg-tiflash

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao
test tidb actually push down
4097d24 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao
Merge remote-tracking branch 'origin/impl-hex-int-str-arg-tiflash' in…
81234c3 
…to impl-hex-int-str-arg-tiflash
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 4, 2022
@YangKeao
Copy link
Member Author

YangKeao commented Aug 4, 2022

@YangKeao friendly ping~ any updated?

Thanks for your remind, I nearly forgot this PR 😢 . Tests have been added. PTAL 😸

@sre-bot
Copy link
Contributor

sre-bot commented Aug 4, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/ca8be72698f32e5ed304ac6211473c5cad3302e7

SeaRise
SeaRise reviewed Aug 4, 2022
View reviewed changes
@SeaRise
Copy link
Contributor

SeaRise commented Aug 4, 2022

/cc @gengliqi

@ti-chi-bot ti-chi-bot requested a review from gengliqi August 4, 2022 09:29
YangKeao added 2 commits August 4, 2022 17:35
@YangKeao
add hexstr/hexint test in expr_to_pb_test.go
8c0e690 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao
use CreateMockStoreAndDomain
8e45af1 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
SeaRise
SeaRise approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 4, 2022
gengliqi
gengliqi approved these changes Aug 5, 2022
View reviewed changes
Copy link
Contributor

@gengliqi gengliqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 5, 2022

@gengliqi: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 5, 2022
@guo-shaoge
Copy link
Collaborator

guo-shaoge commented Aug 5, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 5, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 8e45af1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 5, 2022
@ti-chi-bot ti-chi-bot merged commit cb3fdcc into pingcap:master Aug 5, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 5, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test ✅ all 17 tests passed 12 min Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 31 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 30 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 20 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 11 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 40 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 9 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 52 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guo-shaoge guo-shaoge guo-shaoge approved these changes

+2 more reviewers

@gengliqi gengliqi gengliqi approved these changes

@SeaRise SeaRise SeaRise approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement HexInt/HexStr pushdown

6 participants

@YangKeao @ti-chi-bot @SeaRise @sre-bot @guo-shaoge @gengliqi