Skip to content

parser,ddl: support 'set tiflash mode' ddl and support check tiflash mode in tiflash_replica table#35851

Merged
ti-chi-bot merged 21 commits intopingcap:masterfrom
hongyunyan:hongyunyan_add_set_tiflash_mode_ddl
Jul 7, 2022
Merged

parser,ddl: support 'set tiflash mode' ddl and support check tiflash mode in tiflash_replica table#35851
ti-chi-bot merged 21 commits intopingcap:masterfrom
hongyunyan:hongyunyan_add_set_tiflash_mode_ddl

Conversation

@hongyunyan
Copy link
Contributor

@hongyunyan hongyunyan commented Jun 30, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #35850

Problem Summary:

What is changed and how it works?

  1. support 'set tiflash mode' ddl
  2. support check tiflash mode in tiflash_replica table

need todo later:

  • update tiflash_replica doc infos
  • add 'set tiflash mode' user doc

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

test case 1:

create table t1 (a int, b int);
select * from information_schema.tiflash_replica;
alter table t1 set tiflash replica 1;
select * from information_schema.tiflash_replica;
alter table t1 set tiflash mode fast;
select * from information_schema.tiflash_replica;
alter table t1 set tiflash mode normal;
 select * from information_schema.tiflash_replica;

image

test case 2:

create table t2 (a int, b int);
alter table t2 set tiflash mode fast;
select * from information_schema.tiflash_replica;
alter table t2 set tiflash replica 1;
select * from information_schema.tiflash_replica;

image

test case 3:

create table t3 (x int) partition by range (x) (partition p0 values less than (5),partition p1 values less than (10));
alter table t3 set tiflash replica 1;
alter table t3 set tiflash mode normal;
select * from information_schema.tiflash_replica;

image

test case 4:

alter table t3 set tiflash mode noraml;

image

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 30, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breezewish
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 30, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 30, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 30, 2022
@hongyunyan hongyunyan mentioned this pull request Jul 1, 2022
Merged
12 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Jul 1, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/9c3ec7167146f3c0807835e06e1e069fe7a336f4

@flowbehappy
Copy link
Contributor

flowbehappy commented Jul 1, 2022

@hongyunyan Can you show some examples in the pr comments?

@hongyunyan
Copy link
Contributor Author

hongyunyan commented Jul 1, 2022

/rebuild

@hongyunyan
Copy link
Contributor Author

hongyunyan commented Jul 1, 2022

/rebuild

@hongyunyan
Copy link
Contributor Author

hongyunyan commented Jul 1, 2022

/rebuild

xhebox
xhebox reviewed Jul 1, 2022
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. But any spec or other documents for this?

@hongyunyan
Copy link
Contributor Author

hongyunyan commented Jul 1, 2022

Spec link: https://pingcap.feishu.cn/docx/doxcnzIaCYk6iry0luVREs4CACg

@hongyunyan
Copy link
Contributor Author

hongyunyan commented Jul 4, 2022

cc @breezewish

breezewish
breezewish reviewed Jul 4, 2022
View reviewed changes
breezewish
breezewish reviewed Jul 4, 2022
View reviewed changes
breezewish
breezewish reviewed Jul 4, 2022
View reviewed changes
breezewish
breezewish reviewed Jul 4, 2022
View reviewed changes
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM.

@hongyunyan
Copy link
Contributor Author

hongyunyan commented Jul 5, 2022

/rebuild

@breezewish
Copy link
Member

breezewish commented Jul 5, 2022

@crazycs520 Please help take a look, thanks!

@breezewish breezewish added the require-LGT3 Indicates that the PR requires three LGTM. label Jul 5, 2022
breezewish
breezewish reviewed Jul 5, 2022
View reviewed changes
breezewish
breezewish reviewed Jul 5, 2022
View reviewed changes
breezewish
breezewish reviewed Jul 5, 2022
View reviewed changes
breezewish
breezewish reviewed Jul 5, 2022
View reviewed changes
@hongyunyan
Copy link
Contributor Author

hongyunyan commented Jul 5, 2022

/run-check_dev_2-test

hongyunyan and others added 2 commits July 5, 2022 20:11
@hongyunyan @breezewish
Update executor/infoschema_reader_test.go
83d807b 
fix typo

Co-authored-by: Wenxuan <breezewish@outlook.com>
@hongyunyan @breezewish
Update executor/infoschema_reader_test.go
18d37d4 
fix typo

Co-authored-by: Wenxuan <breezewish@outlook.com>
@xhebox
Copy link
Contributor

xhebox commented Jul 6, 2022

/hold

please solve comment #35851 (comment)

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 6, 2022
@hongyunyan
Copy link
Contributor Author

hongyunyan commented Jul 7, 2022

/rebuild

@breezewish breezewish removed require-LGT3 Indicates that the PR requires three LGTM. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 7, 2022
@breezewish
Copy link
Member

breezewish commented Jul 7, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 7, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: fb3cc54

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 7, 2022
@hongyunyan
Copy link
Contributor Author

hongyunyan commented Jul 7, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 6e22e47 into pingcap:master Jul 7, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 7, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test ✅ all 12 tests passed 22 min Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 35 tests passed 24 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 22 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 23 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 42 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 33 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 12 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 31 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 19 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@flowbehappy flowbehappy mentioned this pull request Jul 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhebox xhebox xhebox approved these changes

@breezewish breezewish breezewish approved these changes

@crazycs520 crazycs520 crazycs520 approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@hongyunyan @ti-chi-bot @sre-bot @flowbehappy @breezewish @xhebox @crazycs520