Skip to content

types: fix incompatible implementation of jsonpath extraction (#35320)#35795

Closed
ti-srebot wants to merge 1 commit intopingcap:release-5.4from
ti-srebot:release-5.4-ed5e63a7a0a2
Closed

types: fix incompatible implementation of jsonpath extraction (#35320)#35795
ti-srebot wants to merge 1 commit intopingcap:release-5.4from
ti-srebot:release-5.4-ed5e63a7a0a2

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jun 28, 2022 •
edited
Loading

cherry-pick #35320 to release-5.4
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/35795

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/35795:release-5.4-ed5e63a7a0a2

What problem does this PR solve?

fix incompatible implementation of jsonpath extraction

Issue Number: close #30352

Problem Summary:

/* t */ drop table if exists t;
-- t >> 0 rows affected
/* t */ create table t (a varchar(100));
-- t >> 0 rows affected
/* t */ insert into t values ('{"labels":[{"name":"foo"}]}'),('{"labels":[{"name":"foo"},{"name":"bar"}]}');
-- t >> 2 rows affected
/* t */ select a->'$.labels[*].name' from t;

except:
-- t >> +-----------------------+
-- t    | a->'$.labels[*].name' |
-- t    +-----------------------+
-- t    | ["foo"]               |
-- t    | ["foo", "bar"]        |
-- t    +-----------------------+

actual:
-- t >> +-----------------------+
-- t    | a->'$.labels[*].name' |
-- t    +-----------------------+
-- t    | "foo"                 | <- not an array
-- t    | ["foo", "bar"]        |
-- t    +-----------------------+

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@mengxin9014 @ti-srebot
cherry pick pingcap#35320 to release-5.4
93e750e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 28, 2022

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Contributor Author

ti-srebot commented Jun 28, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 28, 2022
@ti-srebot ti-srebot mentioned this pull request Jun 28, 2022
Merged
12 tasks
@ti-srebot ti-srebot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/5.4-cherry-pick labels Jun 28, 2022
@ti-srebot ti-srebot requested review from xhebox and zanmato1984 June 28, 2022 10:32
@ti-srebot ti-srebot added this to the v5.4.1 milestone Jun 28, 2022
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Jun 28, 2022

@mengxin9014 you're already a collaborator in bot's repo.

@sre-bot
Copy link
Contributor

sre-bot commented Jun 28, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/93e750ef6b7b2731c9bf1258566ef24b48d874d2

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 28, 2022
@mengxin9014
Copy link
Contributor

mengxin9014 commented Jun 28, 2022

/close

@ti-chi-bot ti-chi-bot closed this Jun 28, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 28, 2022

@mengxin9014: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhebox xhebox xhebox approved these changes

@zanmato1984 zanmato1984 Awaiting requested review from zanmato1984

Assignees

@mengxin9014 mengxin9014

Labels

do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. type/5.4-cherry-pick

Projects

None yet

Milestone

v5.4.1

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-srebot @ti-chi-bot @sre-bot @mengxin9014 @xhebox